Change default flags on advertising data packets

In BLELocalDevice constructor, the flags field of the advertising data is set to a default value.
If a new advertising data is passed to BLELocalDevice, then:
     if it has no flags -> default flags are set (if there is enough space)
     if it already has flags -> nothing happens, the already set flags are used

Author: polldo

src/BLEAdvertisingData.cpp

@@ -227,6 +227,11 @@ int BLEAdvertisingData::dataLength() const
   return _dataLength;
 }
 
+bool BLEAdvertisingData::hasFlags() const
+{
+  return _hasFlags;
+}
+
 bool BLEAdvertisingData::addLocalName(const char *localName)
 {
   bool success = false;

src/BLEAdvertisingData.h

@@ -71,6 +71,7 @@ class BLEAdvertisingData {
   uint8_t* data();
   int dataLength() const;
   int remainingLength() const;
+  bool hasFlags() const;
 
 private:
   bool updateRemainingLength(int fieldLength);

src/local/BLELocalDevice.cpp

@@ -217,6 +217,9 @@ void BLELocalDevice::setLocalName(const char *localName)
 void BLELocalDevice::setAdvertisingData(BLEAdvertisingData& advertisingData)
 {
   _advertisingData = advertisingData;
+  if (!_advertisingData.hasFlags()) {
+    _advertisingData.setFlags(BLEFlagsGeneralDiscoverable | BLEFlagsBREDRNotSupported);
+  }
 }
 
 void BLELocalDevice::setScanResponseData(BLEAdvertisingData& scanResponseData)