Skip to content

Commit 9dfaf51

Browse files
authored
Merge pull request #479 from arangodb/feature/fix_312_compatibility
Feature/fix 312 compatibility
2 parents b5c94e8 + daebf00 commit 9dfaf51

File tree

3 files changed

+55
-36
lines changed

3 files changed

+55
-36
lines changed

release_tester/selenium_ui_test/pages/collection_page.py

Lines changed: 38 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -255,21 +255,25 @@ def create_new_collections(self, name, doc_type, is_cluster):
255255
advance_option_sitem.click()
256256
time.sleep(1)
257257

258-
print(f"selecting number of Shards for the {name} \n")
259-
shards = "numberOfShards"
260-
shards_sitem = self.locator_finder_by_id(shards)
261-
shards_sitem.click()
262-
shards_sitem.clear()
263-
shards_sitem.send_keys(Keys.BACKSPACE, "9")
264-
time.sleep(2)
265-
266-
print(f"selecting number of replication factor for {name} \n")
267-
rf = "replicationFactor"
268-
rf_sitem = self.locator_finder_by_id(rf)
269-
rf_sitem.click()
270-
rf_sitem.clear()
271-
rf_sitem.send_keys(Keys.BACKSPACE, "3")
272-
time.sleep(2)
258+
try:
259+
print(f"selecting number of Shards for the {name} \n")
260+
shards = "numberOfShards"
261+
shards_sitem = self.locator_finder_by_id(shards)
262+
shards_sitem.click()
263+
shards_sitem.clear()
264+
shards_sitem.send_keys(Keys.BACKSPACE, "9")
265+
time.sleep(2)
266+
267+
print(f"selecting number of replication factor for {name} \n")
268+
rf = "replicationFactor"
269+
rf_sitem = self.locator_finder_by_id(rf)
270+
rf_sitem.click()
271+
rf_sitem.clear()
272+
rf_sitem.send_keys(Keys.BACKSPACE, "3")
273+
time.sleep(2)
274+
except Exception as e:
275+
print("Might be failed due to forced-one-shard option is enabled, need a fix \n")
276+
print(str(e))
273277
else:
274278
print(f"selecting number of Shards for the {name} \n")
275279
shards = "new-collection-shards"
@@ -1174,8 +1178,9 @@ def create_new_index(self, index_name, value, is_cluster, check=False):
11741178

11751179
print(f"Creating {index_name} index completed \n")
11761180

1177-
def delete_all_index(self, check=False):
1178-
"""this method will delete all the indexes one by one"""
1181+
def delete_index_311(self, check=False):
1182+
"""this method will delete all the indexes one by one for =<3.11.99"""
1183+
self.webdriver.maximize_window()
11791184
try:
11801185
delete = '//*[@id="collectionEditIndexTable"]/tbody/tr[2]/th[10]/span'
11811186
if check:
@@ -1191,9 +1196,11 @@ def delete_all_index(self, check=False):
11911196
self.webdriver.refresh()
11921197
except TimeoutException as e:
11931198
print('Something went wrong', e, '\n')
1199+
self.webdriver.set_window_size(1600, 900)
11941200

1195-
def delete_index(self, index):
1196-
"""this method will delete all the indexes one by one"""
1201+
def delete_index_312(self, index):
1202+
"""this method will delete all the indexes one by one for >= 3.12.0"""
1203+
self.webdriver.maximize_window()
11971204
try:
11981205
self.webdriver.refresh()
11991206
self.wait_for_ajax()
@@ -1206,10 +1213,19 @@ def delete_index(self, index):
12061213
delete_sitem = self.locator_finder_by_xpath(delete)
12071214
delete_sitem.click()
12081215
time.sleep(1)
1216+
self.wait_for_ajax()
1217+
12091218
delete_confirmation = "(//button[normalize-space()='Delete'])[1]"
12101219
delete_confirmation_sitem = self.locator_finder_by_xpath(delete_confirmation)
12111220
delete_confirmation_sitem.click()
12121221
time.sleep(1)
1222+
self.wait_for_ajax()
1223+
1224+
delete_final_confirmation = "(//button[@class='chakra-button css-flye6g'])[1]"
1225+
delete_final_confirmation_sitem = self.locator_finder_by_xpath(delete_final_confirmation)
1226+
delete_final_confirmation_sitem.click()
1227+
time.sleep(1)
1228+
self.wait_for_ajax()
12131229

12141230
except TimeoutException as e:
12151231
try:
@@ -1226,7 +1242,9 @@ def delete_index(self, index):
12261242
delete_confirmation_sitem.click()
12271243

12281244
except BaseException as e:
1229-
print('Something went wrong, moving on \n')
1245+
print('Something went wrong', e, '\n')
1246+
self.navbar_goto
1247+
self.webdriver.set_window_size(1600, 900)
12301248

12311249
def select_info_tab(self):
12321250
"""Selecting info tab from the collection submenu"""

release_tester/selenium_ui_test/test_suites/collections_test_suite.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ def test_collection(self):
3232
col.create_new_collections('Test', 0, self.is_cluster)
3333
col.create_new_collections('ComputedValueCol', 0, self.is_cluster)
3434

35-
if col.current_package_version() >= semver.VersionInfo.parse("3.9.100"):
35+
if col.version_is_newer_than("3.9.99"):
3636
col.test_computed_values()
3737

3838
print("checking Search options\n")
39-
if col.current_package_version() >= semver.VersionInfo.parse("3.11.100"):
39+
if col.version_is_newer_than("3.11.99"):
4040
col.checking_search_options()
4141
else:
4242
print("Searching using keyword 'Doc'\n")
@@ -50,9 +50,9 @@ def test_collection(self):
5050
self.webdriver.refresh()
5151

5252
# basic collection page feature check for
53-
if col.current_package_version() >= semver.VersionInfo.parse("3.9.99"):
53+
if col.version_is_newer_than("3.9.99"):
5454
col.select_collection_page()
55-
if col.current_package_version() >= semver.VersionInfo.parse("3.11.99"):
55+
if col.version_is_newer_than("3.11.99"):
5656
print("basic feature will be added later on!")
5757
else:
5858
print("Selecting Settings\n")
@@ -140,7 +140,7 @@ def test_collection(self):
140140
print("Create new index\n")
141141
version = col.current_package_version()
142142

143-
if version >= semver.VersionInfo.parse("3.11.0"):
143+
if col.version_is_newer_than("3.11.0"):
144144
col.create_index('Persistent')
145145
col.create_index('Geo')
146146
col.create_index('Fulltext')
@@ -155,15 +155,15 @@ def test_collection(self):
155155
col.create_new_index("Fulltext", 3, self.is_cluster)
156156
col.create_new_index("TTL", 4, self.is_cluster)
157157

158-
if version <= semver.VersionInfo.parse("3.10.99"):
159-
if version > semver.VersionInfo.parse("3.9.99"):
158+
if col.version_is_older_than("3.10.99"):
159+
if col.version_is_newer_than("3.9.99"):
160160
col.create_new_index('ZKD', 5, self.is_cluster, True)
161161
else:
162162
col.create_new_index('ZKD', 5, self.is_cluster)
163163

164164
print("Deleting all index started for < v3.11.x\n")
165165
for i in range(4):
166-
col.delete_all_index(True)
166+
col.delete_index_311(True)
167167
print("Deleting all index completed\n")
168168
else:
169169
print("Deleting all index started for > v3.11.x\n")
@@ -172,10 +172,10 @@ def test_collection(self):
172172
col.select_doc_collection()
173173
col.select_index_menu()
174174
for index in range(4):
175-
col.delete_index(index)
175+
col.delete_index_312(index)
176176
print("Deleting all index completed\n")
177177

178-
if col.current_package_version() >= semver.VersionInfo.parse("3.11.99"):
178+
if col.version_is_newer_than("3.11.99"):
179179
print("basic feature will be added later on!")
180180
else:
181181
print("Select Info tab\n")

release_tester/selenium_ui_test/test_suites/support_test_suite.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,13 @@ def test_support(self):
2727
support.manual_link()
2828
print("Checking all AQL Query Language link\n")
2929
support.aql_query_language_link()
30-
print("Checking all Fox Framework link \n")
31-
support.fox_framework_link()
32-
print("Checking all Drivers and Integration links\n")
33-
support.driver_and_integration_link()
34-
print("Checking Community Support tab \n")
35-
support.community_support_link()
30+
if support.version_is_newer_than("3.11.99") and self.is_enterprise:
31+
print("Checking all Fox Framework link \n")
32+
support.fox_framework_link()
33+
print("Checking all Drivers and Integration links\n")
34+
support.driver_and_integration_link()
35+
print("Checking Community Support tab \n")
36+
support.community_support_link()
3637
# print("Checking Rest API tab \n")
3738
# # support.rest_api()
3839

0 commit comments

Comments
 (0)