Skip to content

Commit 9d2220b

Browse files
committed
fix skip critereon
1 parent b70d195 commit 9d2220b

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

release_tester/arangodb/installers/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ def __init__(
396396
def is_version_not_supported(self, version):
397397
""" check whether this edition is supported in version """
398398
ver = semver.VersionInfo.parse(version)
399-
return not (self.minimum_supported_version > ver > self.maximum_supported_version)
399+
return (self.minimum_supported_version > ver > self.maximum_supported_version)
400400

401401
def set_kwargs(self, kwargs):
402402
"""pick values from the commandline arguments that should override defaults"""

release_tester/full_download_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ def package_test(
6060
if props.directory_suffix not in editions:
6161
continue
6262
if props.is_version_not_supported(new_version):
63+
print(f"skipping {repr(props)}")
6364
continue
6465
props.set_kwargs(kwargs)
6566
dl_opt = deepcopy(dl_opts)
@@ -98,6 +99,10 @@ def package_test(
9899
)
99100
results.append(test_driver.run_test("all", [dl_new.cfg.version], props))
100101

102+
if dl_new is None:
103+
print("no suites found")
104+
return 1
105+
101106
if run_test_suites:
102107
results.append(
103108
[

0 commit comments

Comments
 (0)