Skip to content

Commit 10bd6c7

Browse files
authored
[Improvement] Move irrelevant logs to TRACE level (#1035)
1 parent 0593626 commit 10bd6c7

File tree

6 files changed

+14
-16
lines changed

6 files changed

+14
-16
lines changed

pkg/deployment/deployment.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -390,9 +390,9 @@ func (d *Deployment) run() {
390390
}
391391

392392
case <-d.inspectTrigger.Done():
393-
log.Debug("Inspect deployment...")
393+
log.Trace("Inspect deployment...")
394394
inspectionInterval = d.inspectDeployment(inspectionInterval)
395-
log.Str("interval", inspectionInterval.String()).Debug("...inspected deployment")
395+
log.Str("interval", inspectionInterval.String()).Trace("...inspected deployment")
396396

397397
case <-d.inspectCRDTrigger.Done():
398398
d.lookForServiceMonitorCRD()
@@ -548,7 +548,7 @@ func (d *Deployment) updateCRSpec(ctx context.Context, newSpec api.DeploymentSpe
548548

549549
if len(force) == 0 || !force[0] {
550550
if d.apiObject.Spec.Equal(&newSpec) {
551-
d.log.Debug("Nothing to update in updateCRSpec")
551+
d.log.Trace("Nothing to update in updateCRSpec")
552552
// Nothing to update
553553
return nil
554554
}

pkg/deployment/deployment_inspector.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func (d *Deployment) inspectDeployment(lastInterval util.Interval) util.Interval
6262
ctxReconciliation, cancelReconciliation := globals.GetGlobalTimeouts().Reconciliation().WithTimeout(context.Background())
6363
defer cancelReconciliation()
6464
defer func() {
65-
d.log.Info("Inspect loop took %s", time.Since(start))
65+
d.log.Trace("Inspect loop took %s", time.Since(start))
6666
}()
6767

6868
nextInterval := lastInterval
@@ -152,7 +152,7 @@ func (d *Deployment) inspectDeploymentWithError(ctx context.Context, lastInterva
152152
t := time.Now()
153153

154154
defer func() {
155-
d.log.Info("Reconciliation loop took %s", time.Since(t))
155+
d.log.Trace("Reconciliation loop took %s", time.Since(t))
156156
}()
157157

158158
// Ensure that spec and status checksum are same

pkg/deployment/resources/annotations.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ type PatchFunc func(name string, d []byte) error
4444
func (r *Resources) EnsureAnnotations(ctx context.Context, cachedStatus inspectorInterface.Inspector) error {
4545
log := r.log.Str("section", "annotations")
4646

47-
log.Info("Ensuring annotations")
47+
log.Trace("Ensuring annotations")
4848

4949
patchSecret := func(name string, d []byte) error {
5050
return globals.GetGlobalTimeouts().Kubernetes().RunWithTimeout(ctx, func(ctxChild context.Context) error {

pkg/deployment/resources/inspector/inspector.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -344,14 +344,14 @@ func (i *inspectorState) refreshInThreads(ctx context.Context, threads int, load
344344
logger := logger.Str("namespace", i.namespace).Str("name", i.deploymentName)
345345

346346
start := time.Now()
347-
logger.Debug("Pre-inspector refresh start")
347+
logger.Trace("Pre-inspector refresh start")
348348
d, err := i.client.Arango().DatabaseV1().ArangoDeployments(i.namespace).Get(context.Background(), i.deploymentName, meta.GetOptions{})
349349
n.deploymentResult = &inspectorStateDeploymentResult{
350350
depl: d,
351351
err: err,
352352
}
353353

354-
logger.Debug("Inspector refresh start")
354+
logger.Trace("Inspector refresh start")
355355

356356
for id := range loaders {
357357
go func(id int) {
@@ -362,14 +362,14 @@ func (i *inspectorState) refreshInThreads(ctx context.Context, threads int, load
362362
t := n.throttles.Get(c)
363363

364364
if !t.Throttle() {
365-
logger.Str("component", string(c)).Debug("Inspector refresh skipped")
365+
logger.Str("component", string(c)).Trace("Inspector refresh skipped")
366366
return
367367
}
368368

369-
logger.Str("component", string(c)).Debug("Inspector refresh")
369+
logger.Str("component", string(c)).Trace("Inspector refresh")
370370

371371
defer func() {
372-
logger.Str("component", string(c)).SinceStart("duration", start).Debug("Inspector done")
372+
logger.Str("component", string(c)).SinceStart("duration", start).Trace("Inspector done")
373373
t.Delay()
374374
}()
375375

@@ -384,7 +384,7 @@ func (i *inspectorState) refreshInThreads(ctx context.Context, threads int, load
384384

385385
m.Wait()
386386

387-
logger.SinceStart("duration", start).Debug("Inspector refresh done")
387+
logger.SinceStart("duration", start).Trace("Inspector refresh done")
388388

389389
for id := range loaders {
390390
if err := loaders[id].Verify(n); err != nil {

pkg/deployment/resources/labels.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import (
4040
func (r *Resources) EnsureLabels(ctx context.Context, cachedStatus inspectorInterface.Inspector) error {
4141
log := r.log.Str("section", "labels")
4242

43-
log.Debug("Ensure labels")
43+
log.Trace("Ensure labels")
4444

4545
if err := r.EnsureSecretLabels(ctx, cachedStatus); err != nil {
4646
return err

pkg/operator/operator_deployment.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ func (o *Operator) onUpdateArangoDeployment(oldObj, newObj interface{}) {
7777
defer o.Dependencies.LivenessProbe.Unlock()
7878

7979
apiObject := newObj.(*api.ArangoDeployment)
80-
o.log.
81-
Str("name", apiObject.GetObjectMeta().GetName()).
82-
Debug("ArangoDeployment updated")
80+
o.log.Str("name", apiObject.GetObjectMeta().GetName()).Trace("ArangoDeployment updated")
8381
o.syncArangoDeployment(apiObject)
8482
}
8583

0 commit comments

Comments
 (0)