The local appium process does not stop with SIGINT or SIGTERM

[VitaliiPivtorak]

Do I have the most recent component updates?

• I use the most recent available driver/plugin and server versions

Is the component officially supported by the Appium team?

• I have verified the component repository is present under the Appium organization in GitHub

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

During test run Appium generate huge amount of files *.response (like /private/var/folders/v6/fj6k1y_97yz990kh7rpjrvgm0000gp/T/8f1e5b3c-8bd6-44e6-8ddf-142f9e2537f3.response) and not deleted after. I have 240 tests which runs 3-5 times per day and on 3d day temp folder size more then 300GB.
Screen shot attached after run 3 time by 1 test.

Expected Behavior

After finish test run should be option to delete it.

Minimal Reproducible Example

Run test

Environment

• Operating system:Mac OS 13.4.1 (c) (22F770820d)
• Appium server version (output of appium --version):2.0.0-rc.5
• Appium driver(s) and their version(s):- uiautomator2@2.29.2
• Appium plugin(s) and their version(s):
• Node.js version (output of node --version):v18.15.0
• npm version (output of npm --version):9.6.3
• Last component(s) version which did not exhibit the problem:
• Platform and version under test: Pixel 4a,5,5a Android 13
• Real device or emulator/simulator:Real device

Link to Appium Logs

https://gist.github.com/VitaliiPivtorak/36690410feb338a012142b14f610023a

Futher Information

[KazuCocoa]

let me check tonight

[KazuCocoa]

Maybe here: https://github.com/appium/appium/blob/ff62e208d92995cabc35ddcc100ca4483e25b1af/packages/base-driver/lib/express/idempotency.js#L39-L42

[KazuCocoa]

How did you stop the appium process, or did you keep the appium process running?
The temp file is used to handle possible duplicated new session requests, so current implementation in appium keeps the temp file until the appium process gets stopped by SIGINT/SIGTERM.
https://github.com/appium/appium/blob/ff62e208d92995cabc35ddcc100ca4483e25b1af/packages/appium/lib/main.js#L439C26-L439C32
So, probably they will be deleted once you stop the appium process as SIGINT/SIGTERM signal. For example, when I ran an appium xcuitest session on my local appium, it generated similar naming's temp file with the new session request. Once I killed the process with SIGINT, the tmp file had gone.

I wondered how you managed appium process in your test running.

[VitaliiPivtorak]

Using Nunit in OnetimeSetup i do - [OneTimeSetUp]
appiumServer =
new AppiumServiceBuilder().WithAppiumJS(new FileInfo("/usr/local/lib/node_modules/appium/build/lib/main.js"))
.WithIPAddress("127.0.0.1")
.UsingAnyFreePort()
.WithArguments(optionCollector)
.Build();
appiumServer.Start();
and in [OneTimeTearDown]
appiumServer.Dispose();

[KazuCocoa]

Thank you.
It seems like https://github.com/appium/dotnet-client/blob/master/src/Appium.Net/Appium/Service/AppiumLocalService.cs#L132 (in the appiumServer.Dispose();) works as SIGKILL. Then, no resource cleaning happens. The dotnet client should kill the process as sigterm for macOS/Linux.

Lets move to dotnet client repository to explore proper way

[KazuCocoa]

@Dor-bl @laolubenson Do you know the best way to stop the local appium process with SIGINT or SIGTERM instead of SIGKILL in dotnet env? Below is the current implementation. In my research, the Kill() works as SIGKILL. It does not trigger https://github.com/appium/appium/blob/ff62e208d92995cabc35ddcc100ca4483e25b1af/packages/appium/lib/main.js#L439C26-L439C32 to cleanup resources used by Appium.

        private void DestroyProcess()
        {
            if (Service == null)
            {
                return;
            }

            try
            {
                Service.Kill();
            }
            catch (Exception ignored)
            {
            }
            finally
            {
                Service.Close();
            }
        }

https://github.com/appium/dotnet-client/blob/master/src/Appium.Net/Appium/Service/AppiumLocalService.cs#L132

[VitaliiPivtorak]

Method Dispose also call Destroy and then Kill but no delete file, server it self stoped.
private void DestroyProcess()
{
if (Service == null)
{
return;
}

        try
        {
            Service.Kill();
        }
        catch
        {
        }
        finally
        {
            Service.Close();
        }
    }

    /// <summary>
    /// Stops this service if it is currently running.
    /// </summary>
    [MethodImpl(MethodImplOptions.Synchronized)]
    public void Dispose()
    {
        DestroyProcess();
        GC.SuppressFinalize(this);
    }

[Dor-bl]

@VitaliiPivtorak can you share where are those files located? let me check if i can try and repro from my machine

[VitaliiPivtorak]

like /private/var/folders/v6/fj6k1y_97yz990kh7rpjrvgm0000gp/T/8f1e5b3c-8bd6-44e6-8ddf-142f9e2537f3.response
i also checkd server is run and then stoped

[Dor-bl]

I think I found it as well. But not a lot of files there and the biggest one is 2KB
I'll try to take a look on the code later

[VitaliiPivtorak]

on server i have 300+ MB files in few days test run.