fix: Allow update_column to change required for list elements and map values #2798
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values Closes apache#2786 The `update_schema().update_column()` method was not updating the `required` property for list elements or map values. The `_ApplyChanges` visitor's `list()` and `map()` methods always used the original `element_required` and `value_required` values without checking for updates in `self._updates`. This fix modifies both methods to check `self._updates` for the element/value field ID and use the updated `required` value if present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update_schema().update_column()was not updating therequiredproperty for list elements or map values_ApplyChanges.list()to checkself._updatesfor element's required property_ApplyChanges.map()to checkself._updatesfor value's required propertyTest plan
Closes #2786