From 0a6218ce37b4d4f5c2328d9ba0ad1d2942c7fec9 Mon Sep 17 00:00:00 2001 From: geonove Date: Sun, 25 May 2025 14:41:30 +0200 Subject: [PATCH] Use REQUIRE_THROWS_WITH to check for error message --- count/test/count_min_test.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/count/test/count_min_test.cpp b/count/test/count_min_test.cpp index 143be1b8..8b7ae0a7 100644 --- a/count/test/count_min_test.cpp +++ b/count/test/count_min_test.cpp @@ -55,7 +55,7 @@ TEST_CASE("CM init") { TEST_CASE("CM parameter suggestions", "[error parameters]") { // Bucket suggestions - REQUIRE_THROWS(count_min_sketch::suggest_num_buckets(-1.0), "Confidence must be between 0 and 1.0 (inclusive)." ); + REQUIRE_THROWS_WITH(count_min_sketch::suggest_num_buckets(-1.0), "Relative error must be at least 0."); REQUIRE(count_min_sketch::suggest_num_buckets(0.2) == 14); REQUIRE(count_min_sketch::suggest_num_buckets(0.1) == 28); REQUIRE(count_min_sketch::suggest_num_buckets(0.05) == 55); @@ -69,8 +69,8 @@ TEST_CASE("CM parameter suggestions", "[error parameters]") { REQUIRE(count_min_sketch(n_hashes, 272).get_relative_error() <= 0.01); // Hash suggestions - REQUIRE_THROWS(count_min_sketch::suggest_num_hashes(10.0), "Confidence must be between 0 and 1.0 (inclusive)." ); - REQUIRE_THROWS(count_min_sketch::suggest_num_hashes(-1.0), "Confidence must be between 0 and 1.0 (inclusive)." ); + REQUIRE_THROWS_WITH(count_min_sketch::suggest_num_hashes(10.0), "Confidence must be between 0 and 1.0 (inclusive)." ); + REQUIRE_THROWS_WITH(count_min_sketch::suggest_num_hashes(-1.0), "Confidence must be between 0 and 1.0 (inclusive)." ); REQUIRE(count_min_sketch::suggest_num_hashes(0.682689492) == 2); // 1 STDDEV REQUIRE(count_min_sketch::suggest_num_hashes(0.954499736) == 4); // 2 STDDEV REQUIRE(count_min_sketch::suggest_num_hashes(0.997300204) == 6); // 3 STDDEV @@ -161,9 +161,9 @@ TEST_CASE("CM merge - reject", "[reject cases]") { std::vector> sketches = {s1, s2, s3}; // Fail cases - REQUIRE_THROWS(s.merge(s), "Cannot merge a sketch with itself." ); + REQUIRE_THROWS_WITH(s.merge(s), "Cannot merge a sketch with itself." ); for (count_min_sketch sk : sketches) { - REQUIRE_THROWS(s.merge(sk), "Incompatible sketch config." ); + REQUIRE_THROWS_WITH(s.merge(sk), "Incompatible sketch configuration." ); } }