Skip to content

Implement physical and logical codecs in FFI #19079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timsaucer wants to merge 3 commits into
base: main
Choose a base branch
from
+1,439 −7
Open

Implement physical and logical codecs in FFI #19079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a62c4fb
Implement physical and logical codecs
timsaucer Nov 21, 2025
f572518
Add docstrings
timsaucer Dec 4, 2025
970e9e1
Resolve a handful of reviewer comments
timsaucer Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions datafusion/ffi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,15 @@ arrow-schema = { workspace = true }
async-ffi = { version = "0.5.0", features = ["abi_stable"] }
async-trait = { workspace = true }
datafusion = { workspace = true, default-features = false }
datafusion-catalog = { workspace = true }
datafusion-common = { workspace = true }
datafusion-datasource = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
datafusion-physical-expr = { workspace = true }
datafusion-physical-expr-common = { workspace = true }
datafusion-physical-plan = { workspace = true }
Comment on lines +50 to +58
Copy link
Member Author

@timsaucer timsaucer Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the last PR we are adding these crates in explicitly to reduce the PR size when we remove datafusion dependency.

datafusion-proto = { workspace = true }
datafusion-proto-common = { workspace = true }
futures = { workspace = true }
Expand All @@ -63,6 +66,10 @@ tokio = { workspace = true }

[dev-dependencies]
datafusion = { workspace = true, default-features = false, features = ["sql"] }
datafusion-functions = { workspace = true }
datafusion-functions-aggregate = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
datafusion-functions-window = { workspace = true }
doc-comment = { workspace = true }

[features]
Expand Down
2 changes: 1 addition & 1 deletion datafusion/ffi/src/execution_plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ impl ExecutionPlan for ForeignExecutionPlan {
}

#[cfg(test)]
mod tests {
pub(crate) mod tests {
use super::*;
use arrow::datatypes::{DataType, Field, Schema};
use datafusion::{
Expand Down
1 change: 1 addition & 0 deletions datafusion/ffi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ pub mod expr;
pub mod insert_op;
pub mod physical_expr;
pub mod plan_properties;
pub mod proto;
pub mod record_batch_stream;
pub mod schema_provider;
pub mod session_config;
Expand Down
Loading