-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
Is your feature request related to a problem or challenge?
Currently the to_timestamp set of functions do not have a consistent set of arguments among them. As an example the to_timestamp function supports Float64 and Decimal128(.) however not all the other functions do. It's questionable whether supporting Float64 and Decimal128 is even appropriate for these functions but I'll leave that to another time.
The docs for these functions say: "Supports strings, integer, unsigned integer, and double types as input." however unsigned integers are not supported in any code directly. I do not believe type coercion would be invoked by DF before calling this function as the signature is Signature::variadic_any(Volatility::Immutable)
Given the above, I believe all the to_timestamp functions should be consistent and support:
- all the int* types
- all the uint* types
- all the utf8* types
- all the float types
- I'm on the fence for Decimal128 but there was a reason for it - Decimal type support for
to_timestamp#15486
Describe the solution you'd like
Updated code, tests to cover every single allowed type.
Describe alternatives you've considered
No response
Additional context
No response