Cannot remove Secondary storage after using new feature "migration of secondary storage"

[AlexanderKgr]

ISSUE TYPE

• Bug Report

COMPONENT NAME

API

CLOUDSTACK VERSION

4.15

SUMMARY

After migration finishes cannot delete secondary storage

STEPS TO REPRODUCE

1. Migrate data from image store choosing complete migration policy
   

After a couple of minutes

2. After i tried to delete secondary storage and i have the following message
   

EXPECTED RESULTS

After running migration successfully i thought that i could delete the secondary storage without problem.
The same procedure for primary storage works perfectly so i thought it would be the same.
There is no info for deleting secondary storage at documentation

ACTUAL RESULTS

Cannot delete secondary storage after migration

[DaanHoogland]

@AlexanderKgr are there system templates still on that secstor?

[AlexanderKgr]

@AlexanderKgr are there system templates still on that secstor?

yes there are system templates because there are other image stores - secondary storages.
Also there is the secondary storage that i migrated from this that i want to delete

[DaanHoogland]

@AlexanderKgr can you test @Pearl1594 's fix in #4615? it is allowing for deleting a secstor if no private templates are on it, ignoring public (builtin) templates.

[AlexanderKgr]

@AlexanderKgr can you test @Pearl1594 's fix in #4615? it is allowing for deleting a secstor if no private templates are on it, ignoring public (builtin) templates.

will check and report

[AlexanderKgr]

@AlexanderKgr can you test @Pearl1594 's fix in #4615? it is allowing for deleting a secstor if no private templates are on it, ignoring public (builtin) templates.

i am quite new to debug of cloudstack. can you help how to implement the fix? searching for the 2 files that have been changed but i cannot find them

[DaanHoogland]

@AlexanderKgr You'll need to build the PR version and upgrade a test environment to that version to be able to test it.

[yadvr]

Fixed in #4615

[AlexanderKgr]

@rohityadavcloud @Pearl1594
tried to delete secondary storage at 4.18.0 and faced the same issue.

Migrated all data - complete migrate.
and then

should i report it again?

[Pearl1594]

@AlexanderKgr Would it be possible for you to confirm if there are any private templates still present on the secondary storage from where resources were migrated.Also, on re-attempting migration, do you see any errors reported. It could so happen that when attempting to migrate the resource(s) it encountered some failure. These left over templates/snaps/volumes would prevent deletion of the secondary storage

[AlexanderKgr]

@AlexanderKgr Would it be possible for you to confirm if there are any private templates still present on the secondary storage from where resources were migrated.Also, on re-attempting migration, do you see any errors reported. It could so happen that when attempting to migrate the resource(s) it encountered some failure. These left over templates/snaps/volumes would prevent deletion of the secondary storage

when doing a complete migration of a secondary storage as admin, why should I check for private templates? complete migration should migrate everything. I wanted to delete the 2nd secondary storage because there have been an issue with the array of disks and i couldn't. I have deleted the entry of secondary storage from the database.
I think that, when the admin decides to do a complete migration it should migrate everything. Volumes templates etc... I haven't any errors from the migrations. And after the migration it should be possible to remove the secondary storage.