Quota calculation is incorrect

[huadream]

ISSUE TYPE

• Bug Report

COMPONENT NAME

Quota

CLOUDSTACK VERSION

master branch

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

cloudstack/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java

Line 101 in 1d05fea

String aggregationRange = configs.get("usage.stats.job.aggregation.range");

The default value of usage.stats.job.aggregation.range is 1440.
_aggregationDuration = Integer.parseInt(aggregationRange);

cloudstack/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java

Line 142 in 1d05fea

BigDecimal aggregationRatio = new BigDecimal(_aggregationDuration).divide(s_minutesInMonth, 8, RoundingMode.HALF_EVEN);

The value of aggregationRatio calculated is 1440/(30 * 24 * 60).

All updateQuota* functions have the bug below.

cloudstack/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java

Line 436 in 1d05fea

onehourcost = tariff.getCurrencyValue().multiply(aggregationRatio);

This line would be one-day-cost not one-hour-cost.
So the aggregationRatio should be fixed with 1/(30 * 24).

[yadvr]

Ping @msinhore can be comment ^^

[msinhore]

@rhtyd need to be tested. We have it running in production and no one reported any kind of calculation issue.

[DaanHoogland]

@huadream have you issues with this and a workaround? nobody else complains about this, so either no one uses quota or it is failing only for you. As you have pinpointed the issue in code, can you submit a PR for fixing it? or alternatively do you think we can close this issue?