allow updating backup offering when only domain id is modified

Pearl1594 · Pearl1594 · commit ce0d334658d6 · 2026-01-07T12:15:27.000-05:00
diff --git a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
@@ -2234,7 +2234,7 @@ public BackupOffering updateBackupOffering(UpdateBackupOfferingCmd updateBackupO
             logger.warn(String.format("Couldn't update Backup offering (%s) with [%s].", backupOfferingVO, String.join(", ", fields)));
         }
 
-        if (success) {
+        if (success || fields.isEmpty()) {
             List<Long> existingDomainIds = backupOfferingDetailsDao.findDomainIds(id);
             Collections.sort(existingDomainIds);
             updateBackupOfferingDomainDetails(id, filteredDomainIds, existingDomainIds);

Original file line number	Diff line number	Diff line change
`@@ -2234,7 +2234,7 @@ public BackupOffering updateBackupOffering(UpdateBackupOfferingCmd updateBackupO`
`2234`	`2234`	`logger.warn(String.format("Couldn't update Backup offering (%s) with [%s].", backupOfferingVO, String.join(", ", fields)));`
`2235`	`2235`	`}`
`2236`	`2236`
`2237`		`- if (success) {`
	`2237`	`+ if (success \|\| fields.isEmpty()) {`
`2238`	`2238`	`List<Long> existingDomainIds = backupOfferingDetailsDao.findDomainIds(id);`
`2239`	`2239`	`Collections.sort(existingDomainIds);`
`2240`	`2240`	`updateBackupOfferingDomainDetails(id, filteredDomainIds, existingDomainIds);`