Improve logs on KVMHAVMActivityChecker (#4705)

Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>

Author: GutoVeronezi

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java

@@ -181,7 +181,7 @@ protected String runScriptRetry(String cmdString, OutputInterpreter interpreter)
         return result;
     }
 
-    public Boolean checkingHB() {
+    public Boolean checkingHeartBeat() {
         // TODO Auto-generated method stub
         return null;
     }

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAChecker.java

@@ -41,7 +41,7 @@ public KVMHAChecker(List<NfsStoragePool> pools, String host) {
      * means heartbeating is stopped definitely
      */
     @Override
-    public Boolean checkingHB() {
+    public Boolean checkingHeartBeat() {
         List<Boolean> results = new ArrayList<Boolean>();
         for (NfsStoragePool pool : _pools) {
             Script cmd = new Script(s_heartBeatPath, _heartBeatCheckerTimeout, s_logger);
@@ -77,6 +77,6 @@ public Boolean checkingHB() {
     public Boolean call() throws Exception {
         // s_logger.addAppender(new org.apache.log4j.ConsoleAppender(new
         // org.apache.log4j.PatternLayout(), "System.out"));
-        return checkingHB();
+        return checkingHeartBeat();
     }
 }

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAVMActivityChecker.java

@@ -42,7 +42,7 @@ public KVMHAVMActivityChecker(final NfsStoragePool pool, final String host, fina
     }
 
     @Override
-    public Boolean checkingHB() {
+    public Boolean checkingHeartBeat() {
         Script cmd = new Script(vmActivityCheckPath, activityScriptTimeout.getStandardSeconds(), LOG);
         cmd.add("-i", nfsStoragePool._poolIp);
         cmd.add("-p", nfsStoragePool._poolMountSourcePath);
@@ -52,11 +52,14 @@ public Boolean checkingHB() {
         cmd.add("-t", String.valueOf(String.valueOf(System.currentTimeMillis() / 1000)));
         cmd.add("-d", String.valueOf(suspectTimeInSeconds));
         OutputInterpreter.OneLineParser parser = new OutputInterpreter.OneLineParser();
+
         String result = cmd.execute(parser);
-        LOG.debug("KVMHAVMActivityChecker pool: " + nfsStoragePool._poolIp);
-        LOG.debug("KVMHAVMActivityChecker result: " + result);
-        LOG.debug("KVMHAVMActivityChecker parser: " + parser.getLine());
-        if (result == null && parser.getLine().contains("DEAD")) {
+        String parsedLine = parser.getLine();
+
+        LOG.debug(String.format("Checking heart beat with KVMHAVMActivityChecker [{command=\"%s\", result: \"%s\", log: \"%s\", pool: \"%s\"}].", cmd.toString(), result, parsedLine, nfsStoragePool._poolIp));
+
+        if (result == null && parsedLine.contains("DEAD")) {
+            LOG.warn(String.format("Checking heart beat with KVMHAVMActivityChecker command [%s] returned [%s]. It is [%s]. It may cause a shutdown of host IP [%s].", cmd.toString(), result, parsedLine, hostIP));
             return false;
         } else {
             return true;
@@ -65,6 +68,6 @@ public Boolean checkingHB() {
 
     @Override
     public Boolean call() throws Exception {
-        return checkingHB();
+        return checkingHeartBeat();
     }
 }