QuantityValue implemented as a fractional number 🐲

Build/build-functions.psm1

@@ -91,7 +91,8 @@ function Start-Tests {
     "UnitsNet.Tests\UnitsNet.Tests.csproj",
     "UnitsNet.NumberExtensions.Tests\UnitsNet.NumberExtensions.Tests.csproj",
     "UnitsNet.NumberExtensions.CS14.Tests\UnitsNet.NumberExtensions.CS14.Tests.csproj",
-    "UnitsNet.Serialization.JsonNet.Tests\UnitsNet.Serialization.JsonNet.Tests.csproj"
+    "UnitsNet.Serialization.JsonNet.Tests\UnitsNet.Serialization.JsonNet.Tests.csproj",
+    "UnitsNet.Serialization.SystemTextJson.Tests\UnitsNet.Serialization.SystemTextJson.csproj"
     )
 
   # Parent dir must exist before xunit tries to write files to it
@@ -130,6 +131,7 @@ function Start-PackNugets {
   $projectPaths = @(
     "UnitsNet\UnitsNet.csproj",
     "UnitsNet.Serialization.JsonNet\UnitsNet.Serialization.JsonNet.csproj",
+    "UnitsNet.Serialization.SystemTextJson\UnitsNet.Serialization.SystemTextJson.csproj",
     "UnitsNet.NumberExtensions\UnitsNet.NumberExtensions.csproj",
     "UnitsNet.NumberExtensions.CS14\UnitsNet.NumberExtensions.CS14.csproj"
     )

Build/init.ps1

@@ -1,4 +1,4 @@
-# Don't allow using undeclared variables
+# Don't allow using undeclared variables
 Set-Strictmode -version latest
 
 $root = (Resolve-Path "$PSScriptRoot\..").Path
@@ -80,7 +80,8 @@ if ($msbuildPath -and !(Test-Path "$msbuildPath/nanoFramework")) {
   Write-Output "Latest VS is: $VsInstance"
 
   # Get extension details according to VS version, starting from VS2022 down to VS2019
-  if($vsInstance.Contains('2022'))
+  # TODO check if the extension for VS2022 is compatible it VS2026
+  if($vsInstance.Contains('2026') -or $vsInstance.Contains('2022'))
   {
       $extensionUrl = "https://github.com/nanoframework/nf-Visual-Studio-extension/releases/download/$vs2022Tag/nanoFramework.Tools.VS2022.Extension.vsix"
       $vsixPath = Join-Path  $tempDir "nanoFramework.Tools.VS2022.Extension.zip"

CodeGen/CodeGen.csproj

@@ -1,15 +1,16 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <LangVersion>latest</LangVersion>
     <Nullable>enable</Nullable>
     <!-- Allow compile with various nullability warnings until fixed. -->
     <WarningsNotAsErrors>8600,8601,8603,8604,8618,8619,8625</WarningsNotAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="Fractions" />
     <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="NuGet.Protocol" />
     <PackageReference Include="Serilog" />

CodeGen/Generators/NanoFrameworkGen/NuspecGenerator.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using CodeGen.JsonTypes;
 
 namespace CodeGen.Generators.NanoFrameworkGen

CodeGen/Generators/QuantityRelationsParser.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Collections.Immutable;
 using System.IO;
 using System.Linq;
 using CodeGen.Exceptions;
@@ -61,7 +62,7 @@ public static void ParseAndApplyRelations(string rootDir, Quantity[] quantities)
                     RightUnit = r.LeftUnit,
                 })
                 .ToList());
-            
+
             // We can infer division relations from multiplication relations.
             relations.AddRange(relations
                 .Where(r => r is { Operator: "*", NoInferredDivision: false })
@@ -91,7 +92,7 @@ public static void ParseAndApplyRelations(string rootDir, Quantity[] quantities)
                 var list = string.Join("\n  ", duplicates);
                 throw new UnitsNetCodeGenException($"Duplicate inferred relations:\n  {list}");
             }
-            
+
             var ambiguous = relations
                 .GroupBy(r => $"{r.LeftQuantity.Name} {r.Operator} {r.RightQuantity.Name}")
                 .Where(g => g.Count() > 1)
@@ -133,12 +134,14 @@ private static List<QuantityRelation> ParseRelations(string rootDir, IReadOnlyDi
             try
             {
                 var text = File.ReadAllText(relationsFileName);
-                var relationStrings = JsonConvert.DeserializeObject<SortedSet<string>>(text) ?? [];
 
-                var parsedRelations = relationStrings.Select(relationString => ParseRelation(relationString, quantities)).ToList();
+                // Explicitly sort to keep the file consistent.
+                var relationStringsOrdered = (JsonConvert.DeserializeObject<List<string>>(text) ?? []).ToImmutableSortedSet(StringComparer.OrdinalIgnoreCase);
+
+                var parsedRelations = relationStringsOrdered.Select(relationString => ParseRelation(relationString, quantities)).ToList();
 
                 // File parsed successfully, save it back to disk in the sorted state.
-                File.WriteAllText(relationsFileName, JsonConvert.SerializeObject(relationStrings, Formatting.Indented));
+                File.WriteAllText(relationsFileName, JsonConvert.SerializeObject(relationStringsOrdered, Formatting.Indented));
 
                 return parsedRelations;
             }
@@ -210,4 +213,4 @@ Unit GetUnit(Quantity quantity, string? unitName)
             }
         }
     }
-}
+}

CodeGen/Generators/UnitsNetGen/NumberExtensionsCS14Generator.cs

@@ -53,16 +53,16 @@ public static class NumberTo{_quantityName}Extensions
                     continue;
 
                 Writer.WL(3, $@"
-/// <inheritdoc cref=""{_quantityName}.From{unit.PluralName}(double)"" />");
+/// <inheritdoc cref=""{_quantityName}.From{unit.PluralName}(QuantityValue)"" />");
 
                 // Include obsolete text from the quantity per extension method, to make it visible when the class is not explicitly referenced in code.
                 Writer.WLIfText(3, GetObsoleteAttributeOrNull(unit.ObsoleteText ?? _quantity.ObsoleteText));
 
                 Writer.WL(3, $@"public {_quantityName} {unit.PluralName}
 #if NET7_0_OR_GREATER
-                => {_quantityName}.From{unit.PluralName}(double.CreateChecked(value));
+                => {_quantityName}.From{unit.PluralName}(QuantityValue.CreateChecked(value));
 #else
-                => {_quantityName}.From{unit.PluralName}(value.ToDouble(null));
+                => {_quantityName}.From{unit.PluralName}(value.ToQuantityValue());
 #endif
 ");
             }

CodeGen/Generators/UnitsNetGen/NumberExtensionsGenerator.cs

@@ -40,7 +40,7 @@ public static class NumberTo{_quantityName}Extensions
                     continue;
 
                 Writer.WL(2, $@"
-/// <inheritdoc cref=""{_quantityName}.From{unit.PluralName}(double)"" />");
+/// <inheritdoc cref=""{_quantityName}.From{unit.PluralName}(QuantityValue)"" />");
 
                 // Include obsolete text from the quantity per extension method, to make it visible when the class is not explicitly referenced in code.
                 Writer.WLIfText(2, GetObsoleteAttributeOrNull(unit.ObsoleteText ?? _quantity.ObsoleteText));
@@ -49,10 +49,10 @@ public static class NumberTo{_quantityName}Extensions
             where T : notnull
 #if NET7_0_OR_GREATER
             , INumber<T>
-            => {_quantityName}.From{unit.PluralName}(double.CreateChecked(value));
+            => {_quantityName}.From{unit.PluralName}(QuantityValue.CreateChecked(value));
 #else
             , IConvertible
-            => {_quantityName}.From{unit.PluralName}(value.ToDouble(null));
+            => {_quantityName}.From{unit.PluralName}(value.ToQuantityValue());
 #endif
 ");
             }