fixup! build: update to bazel version 8.4.2

Author: alan-agius4

BUILD.bazel

@@ -2,7 +2,9 @@ load("@aspect_rules_ts//ts:defs.bzl", rules_js_tsconfig = "ts_config")
 load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
 load("@devinfra//bazel/validation:defs.bzl", "validate_ts_version_matching")
 load("@npm//:defs.bzl", "npm_link_all_packages")
+load("@rules_cc//cc:defs.bzl", "cc_toolchain")
 load("//tools:defaults.bzl", "copy_to_bin")
+load("//tools:dummy_cc_toolchain.bzl", "dummy_cc_toolchain_config")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -111,7 +113,7 @@ validate_ts_version_matching(
 
 # This is needed following https://github.com/bazel-contrib/rules_nodejs/pull/3859
 toolchain(
-    name = "node22_windows_no_exec_config_toolchain",
+    name = "node22_windows_no_exec_toolchain",
     exec_compatible_with = [],
     target_compatible_with = [
         "@platforms//os:windows",
@@ -120,3 +122,33 @@ toolchain(
     toolchain = "@node22_windows_amd64//:toolchain",
     toolchain_type = "@rules_nodejs//nodejs:toolchain_type",
 )
+
+# This defines a dummy C++ toolchain for Windows.
+# Without this, the build fails with "Unable to find a CC toolchain using toolchain resolution".
+dummy_cc_toolchain_config(name = "dummy_cc_toolchain_config")
+
+filegroup(name = "empty")
+
+cc_toolchain(
+    name = "dummy_cc_toolchain",
+    all_files = ":empty",
+    compiler_files = ":empty",
+    dwp_files = ":empty",
+    linker_files = ":empty",
+    objcopy_files = ":empty",
+    strip_files = ":empty",
+    supports_param_files = 0,
+    toolchain_config = ":dummy_cc_toolchain_config",
+    toolchain_identifier = "dummy_cc_toolchain",
+)
+
+toolchain(
+    name = "dummy_cc_windows_no_exec_toolchain",
+    exec_compatible_with = [],
+    target_compatible_with = [
+        "@platforms//os:windows",
+        "@platforms//cpu:x86_64",
+    ],
+    toolchain = ":dummy_cc_toolchain",
+    toolchain_type = "@rules_cc//cc:toolchain_type",
+)

MODULE.bazel

@@ -9,17 +9,8 @@ bazel_dep(name = "yq.bzl", version = "0.3.2")
 bazel_dep(name = "rules_nodejs", version = "6.6.2")
 bazel_dep(name = "aspect_rules_js", version = "2.8.3")
 bazel_dep(name = "aspect_rules_ts", version = "3.7.1")
-bazel_dep(name = "rules_pkg", version = "0.8.1")
-
-# Alow for usage of rules_pkg@0.8.1 even though other deps want a later verison.
-multiple_version_override(
-    module_name = "rules_pkg",
-    versions = [
-        "0.8.1",
-        "1.1.0",
-    ],
-)
-
+bazel_dep(name = "rules_pkg", version = "1.1.0")
+bazel_dep(name = "rules_cc", version = "0.1.1")
 bazel_dep(name = "aspect_bazel_lib", version = "2.22.0")
 bazel_dep(name = "bazel_skylib", version = "1.8.2")
 bazel_dep(name = "aspect_rules_esbuild", version = "0.24.0")
@@ -105,9 +96,6 @@ use_repo(
     "node24_windows_amd64",
 )
 
-# This is needed following https://github.com/bazel-contrib/rules_nodejs/pull/3859
-register_toolchains("//:node22_windows_no_exec_config_toolchain")
-
 npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm")
 npm.npm_translate_lock(
     name = "npm",
@@ -173,4 +161,6 @@ register_toolchains(
     "@devinfra//bazel/git-toolchain:git_macos_x86_toolchain",
     "@devinfra//bazel/git-toolchain:git_macos_arm64_toolchain",
     "@devinfra//bazel/git-toolchain:git_windows_toolchain",
+    "//:dummy_cc_windows_no_exec_toolchain",
+    "//:node22_windows_no_exec_toolchain",
 )

MODULE.bazel.lock

@@ -81,7 +81,6 @@ pkg_tar(
     name = "npm_package_archive",
     srcs = [":npm_package"],
     extension = "tgz",
-    strip_prefix = "./npm_package",
     # should not be built unless it is a dependency of another rule
     tags = ["manual"],
 )

packages/angular/ssr/BUILD.bazel

@@ -403,7 +403,7 @@ async function findPackageTars(): Promise<{ [pkg: string]: PkgInfo }> {
   );
 
   const pkgJsons = await Promise.all(
-    pkgs.map((pkg) => realpathSync(pkg)).map((pkg) => extractFile(pkg, './package.json')),
+    pkgs.map((pkg) => realpathSync(pkg)).map((pkg) => extractFile(pkg, 'npm_package/package.json')),
   );
 
   return pkgs.reduce(

tests/legacy-cli/e2e_runner.ts

@@ -119,6 +119,5 @@ def npm_package(
             name = "npm_package_archive",
             srcs = [":pkg"],
             extension = "tgz",
-            strip_prefix = "./npm_package",
             visibility = visibility,
         )

tools/bazel/npm_package.bzl

@@ -0,0 +1,28 @@
+"""
+This file defines a dummy C++ toolchain for Windows.
+It is needed to satisfy Bazel's toolchain resolution when cross-compiling for Windows on Linux.
+Some rules (e.g. rules_nodejs, js_test) or their dependencies may trigger C++ toolchain resolution
+even if no actual C++ compilation is performed for the target platform.
+Without this, the build fails with "Unable to find a CC toolchain using toolchain resolution".
+"""
+
+load("@rules_cc//cc:defs.bzl", "cc_common")
+
+def _impl(ctx):
+    return cc_common.create_cc_toolchain_config_info(
+        ctx = ctx,
+        toolchain_identifier = "dummy-toolchain",
+        host_system_name = "local",
+        target_system_name = "local",
+        target_cpu = "x64_windows",
+        target_libc = "unknown",
+        compiler = "dummy",
+        abi_version = "unknown",
+        abi_libc_version = "unknown",
+    )
+
+dummy_cc_toolchain_config = rule(
+    implementation = _impl,
+    attrs = {},
+    provides = [CcToolchainConfigInfo],
+)