Skip to content

Detective can not handle barrel files #36

@timonkrebs

Description

@timonkrebs

Thank you very much for this awesome tool. I really like working with it. But I found an Issue:

Issue

Run detective on https://github.com/angular/angular/tree/main/adev.

You will get an error:

npx @softarc/detective detective

/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/sheriff-core/src/lib/file-info/get-ts-config-context.js:78
                throw new user_error_1.InvalidPathError(key, value);
                ^

InvalidPathError: invalid path mapping detected: selenium-webdriver: ./node_modules/@types/selenium-webdriver/index.d.ts. Please verify that the path exists.
    at getTsConfigContext (/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/sheriff-core/src/lib/file-info/get-ts-config-context.js:78:23)
    at generateTsData (/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/sheriff-core/src/lib/file-info/generate-ts-data.js:50:74)
    at init (/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/sheriff-core/src/lib/main/init.js:21:58)
    at getProjectData (/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/sheriff-core/src/lib/api/get-project-data.js:33:41)
    at /home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/detective/main.js:822:55
    at Array.map (<anonymous>)
    at inferDeps (/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/detective/main.js:822:10)
    at /home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/detective/main.js:1475:27
    at /home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/detective/main.js:1493:3
    at Object.<anonymous> (/home/codespace/.npm/_npx/45f60c1b8fa1be30/node_modules/@softarc/detective/main.js:1495:12) {
  code: 'SH-001'
}

It does not work because of these files:

 /workspaces/angular/packages/platform-browser/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/common/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/common/http/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/core/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/router/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/core/rxjs-interop/src/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/forms/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/platform-browser/animations/async/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/animations/public_api.ts /workspaces/angular/adev
 /workspaces/angular/packages/platform-browser/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/common/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/common/http/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/core/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/router/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/core/rxjs-interop/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/forms/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/platform-browser/animations/async/index.ts /workspaces/angular/adev
 /workspaces/angular/packages/animations/index.ts /workspaces/angular/adev

Maybe this could be a hint for further investigation:
https://github.com/angular/angular/blob/1f4ff2fa36f5d6240cbc4a40839d3d89501519d8/tools/defaults.bzl#L172

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions