Skip to content

Commit 9a59cc7

Browse files
committed
Add parameters to Messages#list
1 parent a110864 commit 9a59cc7

File tree

5 files changed

+25
-25
lines changed

5 files changed

+25
-25
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ If the `status` response indicates that the `run` is `completed`, the associated
682682

683683
```ruby
684684
# Either retrieve all messages in bulk again, or...
685-
messages = client.messages.list(thread_id: thread_id) # Note: as of 2023-12-11 adding limit or order options isn't working, yet
685+
messages = client.messages.list(thread_id: thread_id, parameters: { order: 'asc' })
686686

687687
# Alternatively retrieve the `run steps` for the run which link to the messages:
688688
run_steps = client.run_steps.list(thread_id: thread_id, run_id: run_id, parameters: { order: 'asc' })

lib/openai/messages.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ def initialize(client:)
44
@client = client.beta(assistants: "v1")
55
end
66

7-
def list(thread_id:)
8-
@client.get(path: "/threads/#{thread_id}/messages")
7+
def list(thread_id:, parameters: {})
8+
@client.get(path: "/threads/#{thread_id}/messages", parameters: parameters)
99
end
1010

1111
def retrieve(thread_id:, id:)

spec/fixtures/cassettes/messages_list.yml

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/fixtures/cassettes/messages_list_thread_setup.yml

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/openai/client/messages_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
describe "#list" do
3434
let(:cassette) { "messages list" }
3535
let(:response) do
36-
OpenAI::Client.new.messages.list(thread_id: thread_id)
36+
OpenAI::Client.new.messages.list(thread_id: thread_id, parameters: { order: "asc" })
3737
end
3838

3939
it "succeeds" do

0 commit comments

Comments
 (0)