Merge pull request #186 from akd-io/feature/185-npm-i-fails-on-windows-with---format

Fix lint-staged + husky bug on Windows

Author: akd-io

packages/create-next-stack/package.json

@@ -91,6 +91,7 @@
     "next": "^13.3.1",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
+    "typescript": "^4.9.5",
     "uuid": "^9.0.0"
   }
 }

packages/create-next-stack/src/main/plugins/formatting-pre-commit-hook.ts

@@ -22,6 +22,16 @@ export const formattingPreCommitHookPlugin = createPlugin({
       version: "^7.0.0",
     },
   },
+  devDependencies: {
+    "lint-staged": {
+      name: "lint-staged",
+      version: ">=10",
+    },
+    husky: {
+      name: "husky",
+      version: ">=7",
+    },
+  },
   technologies: [
     {
       id: "husky",

packages/create-next-stack/src/tests/e2e/helpers/check-formatting-linting-build.ts

@@ -2,8 +2,9 @@ import { Options } from "execa"
 import { runCommand } from "../../../main/helpers/run-command"
 import { logTestInfo } from "../test-logging"
 
-export const checkFormattingLintingBuild = async (
-  runDirectory: string
+export const performE2eChecks = async (
+  runDirectory: string,
+  args: string[]
 ): Promise<void> => {
   const options: Options = {
     cwd: runDirectory,
@@ -21,4 +22,12 @@ export const checkFormattingLintingBuild = async (
 
   logTestInfo("Running build...")
   await runCommand("npm", ["run", "build"], options)
+
+  const packageManager = args
+    .find((arg) => arg.startsWith("--package-manager="))
+    ?.split("=")[1]
+  if (packageManager) {
+    logTestInfo("Installing dependencies...")
+    await runCommand(packageManager, ["install"], options)
+  }
 }

packages/create-next-stack/src/tests/e2e/test-live-cns.ts

@@ -2,7 +2,7 @@ import chalk from "chalk"
 import endent from "endent"
 import { v4 as uuidv4 } from "uuid"
 import { runCommand } from "../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "./helpers/check-formatting-linting-build"
+import { performE2eChecks } from "./helpers/check-formatting-linting-build"
 import { exitWithError } from "./helpers/exit-with-error"
 import { logTestInfo } from "./test-logging"
 ;(async () => {
@@ -21,7 +21,7 @@ import { logTestInfo } from "./test-logging"
 
     await runCommand(command, args, { stdio: "inherit" })
 
-    await checkFormattingLintingBuild(runDirectory)
+    await performE2eChecks(runDirectory, args)
 
     logTestInfo("")
     logTestInfo(endent`

packages/create-next-stack/src/tests/e2e/test-manual.ts

@@ -2,7 +2,7 @@ import chalk from "chalk"
 import endent from "endent"
 import { v4 as uuidv4 } from "uuid"
 import { runCommand } from "../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "./helpers/check-formatting-linting-build"
+import { performE2eChecks } from "./helpers/check-formatting-linting-build"
 import { exitWithError } from "./helpers/exit-with-error"
 import { logTestInfo } from "./test-logging"
 ;(async () => {
@@ -16,7 +16,7 @@ import { logTestInfo } from "./test-logging"
     const args = [...process.argv.slice(2), runDirectory]
     await runCommand(pathToCLI, args, { stdio: "inherit" })
 
-    await checkFormattingLintingBuild(runDirectory)
+    await performE2eChecks(runDirectory, args)
 
     logTestInfo("")
     logTestInfo(endent`

packages/create-next-stack/src/tests/e2e/tests/css-modules-with-sass/css-modules-with-sass-all-flags.ts

@@ -1,5 +1,5 @@
 import { runCommand } from "../../../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "../../helpers/check-formatting-linting-build"
+import { performE2eChecks } from "../../helpers/check-formatting-linting-build"
 import { logTestMeta } from "../../helpers/log-test-meta"
 import { minutesToMilliseconds } from "../../helpers/minutes-to-milliseconds"
 import { prepareE2eTest } from "../../helpers/prepare-e2e-test"
@@ -31,5 +31,5 @@ export const testCssModulesWithSassAllFlags = async (
     stderr: "inherit",
   })
 
-  await checkFormattingLintingBuild(runDirectory)
+  await performE2eChecks(runDirectory, args)
 }

packages/create-next-stack/src/tests/e2e/tests/css-modules-with-sass/css-modules-with-sass-only.ts

@@ -1,5 +1,5 @@
 import { runCommand } from "../../../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "../../helpers/check-formatting-linting-build"
+import { performE2eChecks } from "../../helpers/check-formatting-linting-build"
 import { logTestMeta } from "../../helpers/log-test-meta"
 import { minutesToMilliseconds } from "../../helpers/minutes-to-milliseconds"
 import { prepareE2eTest } from "../../helpers/prepare-e2e-test"
@@ -25,5 +25,5 @@ export const testCssModulesWithSassOnly = async (
     stderr: "inherit",
   })
 
-  await checkFormattingLintingBuild(runDirectory)
+  await performE2eChecks(runDirectory, args)
 }

packages/create-next-stack/src/tests/e2e/tests/css-modules/css-modules-all-flags.ts

@@ -1,5 +1,5 @@
 import { runCommand } from "../../../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "../../helpers/check-formatting-linting-build"
+import { performE2eChecks } from "../../helpers/check-formatting-linting-build"
 import { logTestMeta } from "../../helpers/log-test-meta"
 import { minutesToMilliseconds } from "../../helpers/minutes-to-milliseconds"
 import { prepareE2eTest } from "../../helpers/prepare-e2e-test"
@@ -31,5 +31,5 @@ export const testCssModulesAllFlags = async (
     stderr: "inherit",
   })
 
-  await checkFormattingLintingBuild(runDirectory)
+  await performE2eChecks(runDirectory, args)
 }

packages/create-next-stack/src/tests/e2e/tests/css-modules/css-modules-only.ts

@@ -1,5 +1,5 @@
 import { runCommand } from "../../../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "../../helpers/check-formatting-linting-build"
+import { performE2eChecks } from "../../helpers/check-formatting-linting-build"
 import { logTestMeta } from "../../helpers/log-test-meta"
 import { minutesToMilliseconds } from "../../helpers/minutes-to-milliseconds"
 import { prepareE2eTest } from "../../helpers/prepare-e2e-test"
@@ -25,5 +25,5 @@ export const testCssModulesOnly = async (
     stderr: "inherit",
   })
 
-  await checkFormattingLintingBuild(runDirectory)
+  await performE2eChecks(runDirectory, args)
 }

packages/create-next-stack/src/tests/e2e/tests/emotion/emotion-all-flags.ts

@@ -1,5 +1,5 @@
 import { runCommand } from "../../../../main/helpers/run-command"
-import { checkFormattingLintingBuild } from "../../helpers/check-formatting-linting-build"
+import { performE2eChecks } from "../../helpers/check-formatting-linting-build"
 import { logTestMeta } from "../../helpers/log-test-meta"
 import { minutesToMilliseconds } from "../../helpers/minutes-to-milliseconds"
 import { prepareE2eTest } from "../../helpers/prepare-e2e-test"
@@ -33,5 +33,5 @@ export const testEmotionAllFlags = async (
     stderr: "inherit",
   })
 
-  await checkFormattingLintingBuild(runDirectory)
+  await performE2eChecks(runDirectory, args)
 }