changes for latest typescript version

Author: ajafff

package.json

@@ -47,7 +47,7 @@
     "nyc": "^12.0.1",
     "rimraf": "^2.6.2",
     "tslint": "^5.8.0",
-    "typescript": "~2.8.1"
+    "typescript": "2.9.1"
   },
   "peerDependencies": {
     "tslint": "^5.0.0",

rules/namingConventionRule.ts

@@ -312,7 +312,10 @@ class IdentifierNameWalker extends Lint.AbstractWalker<NormalizedConfig[]> {
         return this._usage.get(name)!.uses.length === 0;
     }
 
-    private _checkTypeParameters(node: ts.DeclarationWithTypeParameters, modifiers: Modifiers) {
+    private _checkTypeParameters(
+        node: ts.SignatureDeclaration | ts.ClassLikeDeclaration | ts.InterfaceDeclaration | ts.TypeAliasDeclaration,
+        modifiers: Modifiers,
+    ) {
         if (node.typeParameters !== undefined)
             for (const {name} of node.typeParameters)
                 this._checkName(name, TypeSelector.genericTypeParameter, modifiers);

rules/noUnnecessaryTypeAnnotationRule.ts

@@ -221,9 +221,11 @@ function walk(ctx: Lint.WalkContext<IOptions>, checker: ts.TypeChecker) {
     }
 
     function signatureHasGenericOrTypePredicateReturn(signature: ts.Signature): boolean {
+        if (signature.declaration === undefined)
+            return false;
         if (signature.declaration.type !== undefined && isTypePredicateNode(signature.declaration.type))
             return true;
-        const original = checker.getSignatureFromDeclaration(signature.declaration);
+        const original = checker.getSignatureFromDeclaration(<ts.SignatureDeclaration>signature.declaration);
         return original !== undefined && isTypeParameter(original.getReturnType());
     }
 
@@ -277,7 +279,10 @@ function walk(ctx: Lint.WalkContext<IOptions>, checker: ts.TypeChecker) {
     function getMatchingSignature(type: ts.Type, parameters: ReadonlyArray<ts.ParameterDeclaration>): [ts.Signature, boolean] | undefined {
         const minArguments = getMinArguments(parameters);
 
-        const signatures = getSignaturesOfType(type).filter((s) => getNumParameters(s.declaration.parameters) >= minArguments);
+        const signatures = getSignaturesOfType(type).filter(
+            (s) => s.declaration !== undefined &&
+                getNumParameters(<ReadonlyArray<ts.ParameterDeclaration>>s.declaration.parameters) >= minArguments,
+        );
 
         switch (signatures.length) {
             case 0:

rules/preferConstEnumRule.ts

@@ -110,8 +110,9 @@ function onlyConstUses(track: IEnum): boolean {
             default:
                 return false;
             case ts.SyntaxKind.ElementAccessExpression:
-                if ((<ts.ElementAccessExpression>parent).argumentExpression === undefined ||
-                    (<ts.ElementAccessExpression>parent).argumentExpression!.kind !== ts.SyntaxKind.StringLiteral)
+                // wotan-disable-next-line no-useless-predicate
+                if ((<ts.ElementAccessExpression>parent).argumentExpression === undefined || // compatibilty with typescript@<2.9.0
+                    (<ts.ElementAccessExpression>parent).argumentExpression.kind !== ts.SyntaxKind.StringLiteral)
                     return false;
                 break;
             case ts.SyntaxKind.PropertyAccessExpression:
@@ -147,7 +148,12 @@ function isConstInitializer(initializer: ts.Expression, members: Map<string, IEn
             return member !== undefined && member.isConst && (allowStrings || !member.stringValued);
         }
         if (isElementAccessExpression(node)) {
-            if (!isIdentifier(node.expression) || node.argumentExpression === undefined || !isStringLiteral(node.argumentExpression))
+            if (
+                !isIdentifier(node.expression) ||
+                // wotan-disable-next-line no-useless-predicate
+                node.argumentExpression === undefined || // compatibility with typescript@<2.9.0
+                !isStringLiteral(node.argumentExpression)
+            )
                 return false;
             const track = findEnum(node.expression);
             if (track === undefined)