enable ts strict mode and remove eslint (#473)

enable ts strict mode and remove eslint

Author: mathieudutour

.eslintignore

@@ -44,13 +44,9 @@ To run tests continuously
 npm run test:watch
 ```
 
-This codebase adheres to the [Airbnb Styleguide](https://github.com/airbnb/javascript) and is enforced using [ESLint](http://eslint.org/).
+This style of the codebase is enforced by [Prettier](https://prettier.io/).
 
-It is recommended that you install an ESlint plugin for your editor of choice when working on this codebase, however you can always check to see if the source code is compliant by running:
-
-```bash
-npm run lint
-```
+It is recommended that you install a Prettier plugin for your editor of choice when working on this codebase.
 
 ### Docs
 
@@ -99,7 +95,7 @@ In general, the contribution workflow looks like this:
 - Open a new issue in the [Issue tracker](https://github.com/airbnb/react-sketchapp/issues).
 - Fork the repo.
 - Create a new feature branch based off the `master` branch.
-- Make sure all tests pass and there are no linting errors.
+- Make sure all tests pass.
 - Submit a pull request, referencing any issues it addresses.
 
 Please try to keep your pull request focused in scope and avoid including unrelated commits.

.eslintrc

@@ -11,8 +11,6 @@ __tests__
 template
 book.json
 prettier.config.js
-.eslintrc
-.eslintignore
 .editorconfig
 .bookignore
 src

.github/CONTRIBUTING.md

@@ -3,7 +3,7 @@
 exports[`<Image /> name defaults to Image 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -12,7 +12,7 @@ exports[`<Image /> name defaults to Image 1`] = `
 exports[`<Image /> name passes its name 1`] = `
 <sketch_image
   name="bar"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -21,7 +21,7 @@ exports[`<Image /> name passes its name 1`] = `
 exports[`<Image /> renders children 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 >
@@ -32,7 +32,7 @@ exports[`<Image /> renders children 1`] = `
 exports[`<Image /> resizeMode falls back to a resizeMode from style 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fit"
+  resizeMode={3}
   source="foo"
   style={
     Object {
@@ -45,7 +45,7 @@ exports[`<Image /> resizeMode falls back to a resizeMode from style 1`] = `
 exports[`<Image /> resizeMode falls back to cover 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -54,7 +54,7 @@ exports[`<Image /> resizeMode falls back to cover 1`] = `
 exports[`<Image /> resizeMode prefers prop to style 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={
     Object {
@@ -67,7 +67,7 @@ exports[`<Image /> resizeMode prefers prop to style 1`] = `
 exports[`<Image /> resizeMode translates center 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -76,7 +76,7 @@ exports[`<Image /> resizeMode translates center 1`] = `
 exports[`<Image /> resizeMode translates contain 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fit"
+  resizeMode={3}
   source="foo"
   style={Object {}}
 />
@@ -85,7 +85,7 @@ exports[`<Image /> resizeMode translates contain 1`] = `
 exports[`<Image /> resizeMode translates cover 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -94,7 +94,7 @@ exports[`<Image /> resizeMode translates cover 1`] = `
 exports[`<Image /> resizeMode translates none 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -103,7 +103,7 @@ exports[`<Image /> resizeMode translates none 1`] = `
 exports[`<Image /> resizeMode translates repeat 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Tile"
+  resizeMode={0}
   source="foo"
   style={Object {}}
 />
@@ -112,7 +112,7 @@ exports[`<Image /> resizeMode translates repeat 1`] = `
 exports[`<Image /> resizeMode translates stretch 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Stretch"
+  resizeMode={2}
   source="foo"
   style={Object {}}
 />
@@ -121,7 +121,7 @@ exports[`<Image /> resizeMode translates stretch 1`] = `
 exports[`<Image /> source falls back to defaultSource if available 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -130,7 +130,7 @@ exports[`<Image /> source falls back to defaultSource if available 1`] = `
 exports[`<Image /> source favors style over source for height 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source={
     Object {
       "height": 500,
@@ -149,7 +149,7 @@ exports[`<Image /> source favors style over source for height 1`] = `
 exports[`<Image /> source favors style over source for width 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source={
     Object {
       "uri": "foo",
@@ -168,7 +168,7 @@ exports[`<Image /> source favors style over source for width 1`] = `
 exports[`<Image /> source prefers source over defaultSource 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source="foo"
   style={Object {}}
 />
@@ -177,7 +177,7 @@ exports[`<Image /> source prefers source over defaultSource 1`] = `
 exports[`<Image /> source sets height from source 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source={
     Object {
       "height": 500,
@@ -196,7 +196,7 @@ exports[`<Image /> source sets height from source 1`] = `
 exports[`<Image /> source sets width from source 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   source={
     Object {
       "uri": "foo",
@@ -215,7 +215,7 @@ exports[`<Image /> source sets width from source 1`] = `
 exports[`<Image /> style accepts a StyleSheet ordinal 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   style={
     Object {
       "flex": 1,
@@ -227,7 +227,7 @@ exports[`<Image /> style accepts a StyleSheet ordinal 1`] = `
 exports[`<Image /> style accepts a plain object 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   style={
     Object {
       "flex": 1,
@@ -239,7 +239,7 @@ exports[`<Image /> style accepts a plain object 1`] = `
 exports[`<Image /> style accepts an array of plain objects and/or StyleSheet ordinals 1`] = `
 <sketch_image
   name="Image"
-  resizeMode="Fill"
+  resizeMode={1}
   style={
     Object {
       "flex": 1,

.npmignore

@@ -1,4 +1,3 @@
-/* eslint-disable global-require */
 import * as React from 'react';
 
 import ReactSketch from '../../../../src';

__tests__/jest/components/__snapshots__/Image.tsx.snap

@@ -1,4 +1,3 @@
-/* eslint-disable global-require */
 import ReactSketch from '../../src';
 jest.mock('../../src/jsonUtils/sketchImpl/createStringMeasurer');
 jest.mock('../../src/jsonUtils/sketchImpl/findFontName');

__tests__/jest/components/nodeImpl/Svg.tsx

@@ -21,6 +21,7 @@ const createTreeNode = (style: { [key: string]: number | string }) => ({
   props: {
     style,
   },
+  children: [],
 });
 
 const createYogaNodes = (

__tests__/jest/index.ts

@@ -31,6 +31,7 @@ const treeRootStub = {
           width: 96,
         },
       },
+      children: [],
     },
   ],
 };

__tests__/jest/jsonUtils/computeYogaNode.ts

@@ -25,6 +25,7 @@ const treeRootStub = {
           zIndex: 1,
         },
       },
+      children: [],
     },
     {
       type: 'view',
@@ -37,6 +38,7 @@ const treeRootStub = {
           zIndex: 3,
         },
       },
+      children: [],
     },
     {
       type: 'view',
@@ -49,6 +51,7 @@ const treeRootStub = {
           zIndex: 2,
         },
       },
+      children: [],
     },
   ],
 };
@@ -85,7 +88,7 @@ describe('Compute Flex Tree', () => {
             width: 100,
             zIndex: 1,
           },
-          textNodes: undefined,
+          textNodes: [],
         },
         children: [],
       },
@@ -114,7 +117,7 @@ describe('Compute Flex Tree', () => {
             width: 200,
             zIndex: 2,
           },
-          textNodes: undefined,
+          textNodes: [],
         },
         children: [],
       },
@@ -143,7 +146,7 @@ describe('Compute Flex Tree', () => {
             width: 300,
             zIndex: 3,
           },
-          textNodes: undefined,
+          textNodes: [],
         },
         children: [],
       },