Commit ae05316
committed
(refactor): w/blist transform args shouldn't be optional
- the array passed into the transforms should be required
- same for arrToDict function
- they're now called only when array is defined, and I think that
behavior is more intuitive -- it should error if the array isn't
defined
- (test): in internal usage, they're never undefined, so this was
reducing coverage because it was dead code
- if the transforms were to eventually be externally visible /
import-able, they should definitely throw an error in that case
too -- if external users pass undefined to it
- and the typings change means it'll happen at design-time too
- definitely think it's more intuitive for external users this
way too
- (docs): use this commit for w/blist transform examples
- or a variant of this commit -- just one where arr is required1 parent 00c1632 commit ae05316
File tree
4 files changed
+4
-9
lines changed- src
4 files changed
+4
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | 8 | | |
11 | 9 | | |
12 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | 8 | | |
11 | 9 | | |
12 | 10 | | |
| |||
0 commit comments