Skip to content

Commit b5ba2d3

Browse files
committed
chore: review suggestions
1 parent 58474d7 commit b5ba2d3

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

2nd-gen/packages/core/components/asset/Asset.base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export abstract class AssetBase extends SpectrumElement {
4545
public variant: AssetVariant | undefined;
4646

4747
/**
48-
* Accessible label for the asset’s SVG variant.
48+
* Accessible label for the asset’s file or folder variant.
4949
*/
5050
@property()
5151
public label = '';

2nd-gen/packages/swc/components/asset/Asset.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,8 @@ const folder = (label: string): TemplateResult => html`
5454
`;
5555

5656
/**
57-
* Use an asset element to visually represent a file, folder, or image.
58-
* File and folder representations center themselves within the available space.
59-
* Images are contained to the element’s size and centered.
60-
*
6157
* @element swc-asset
62-
* @slot - content to be displayed when no `variant` is set (typically an <img>)
58+
* @slot - content to be displayed when no `variant` is set (typically an `<img>` element)
6359
*
6460
* @example
6561
* <swc-asset style="block-size: 128px">

2nd-gen/packages/swc/components/asset/stories/asset.stories.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ argTypes.variant = {
3030
options: [undefined, ...Asset.VARIANTS],
3131
};
3232

33+
/**
34+
* Use an asset element to visually represent a file, folder, or image.
35+
* File and folder representations center themselves within the available space.
36+
* Images are contained to the element’s size and centered.
37+
*/
3338
const meta: Meta = {
3439
title: 'Asset',
3540
component: 'swc-asset',

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
"scripts": {
1818
"build": "yarn build:1st-gen && yarn build:2nd-gen",
1919
"build:1st-gen": "yarn workspace @spectrum-web-components/1st-gen build",
20-
"build:2nd-gen": "yarn workspace @adobe/swc build",
20+
"build:2nd-gen": "yarn workspace @spectrum-web-components/2nd-gen build",
2121
"lint": "yarn lint:1st-gen && yarn lint:2nd-gen",
2222
"lint:1st-gen": "yarn workspace @spectrum-web-components/1st-gen lint",
23-
"lint:2nd-gen": "yarn workspace @adobe/swc lint",
23+
"lint:2nd-gen": "yarn workspace @spectrum-web-components/2nd-gen lint",
2424
"postinstall": "husky || true && patch-package",
2525
"start": "yarn start:1st-gen & yarn start:2nd-gen",
2626
"start:1st-gen": "yarn workspace @spectrum-web-components/1st-gen start",
27-
"start:2nd-gen": "yarn workspace @adobe/swc storybook",
27+
"start:2nd-gen": "yarn workspace @spectrum-web-components/2nd-gen start",
2828
"test": "yarn test:1st-gen & yarn test:2nd-gen",
2929
"test:1st-gen": "yarn workspace @spectrum-web-components/1st-gen test",
30-
"test:2nd-gen": "yarn workspace @adobe/swc test",
30+
"test:2nd-gen": "yarn workspace @spectrum-web-components/2nd-gen test",
3131
"test:a11y": "yarn workspace @spectrum-web-components/1st-gen test:a11y",
3232
"test:a11y:1st": "yarn workspace @spectrum-web-components/1st-gen test:a11y:1st",
3333
"test:a11y:2nd": "yarn workspace @spectrum-web-components/1st-gen test:a11y:2nd",

0 commit comments

Comments
 (0)