fix: always check for forbidden domain code point

Author: anonrig

src/unicode.cpp

@@ -411,10 +411,6 @@ constexpr static uint8_t is_forbidden_domain_code_point_table[] = {
     }
     out.value().resize(length); // we possibly want to call :shrink_to_fit otherwise we use 255 bytes.
     out.value().shrink_to_fit();
-    if(std::any_of(out.value().begin(), out.value().end(), ada::unicode::is_forbidden_domain_code_point)) {
-      out = std::nullopt;
-      return false;
-    }
 #elif defined(_WIN32) && ADA_WINDOWS_TO_ASCII_FALLBACK
     (void)be_strict; // unused.
     // Fallback on the system if ICU is not available.
@@ -525,10 +521,6 @@ constexpr static uint8_t is_forbidden_domain_code_point_table[] = {
     }
     out = std::string(required_buffer_size, 0);
     for(size_t i = 0; i < required_buffer_size; i++) { (*out)[i] = char(ascii_buffer.get()[i]); }
-    if(std::any_of(out.value().begin(), out.value().end(), ada::unicode::is_forbidden_domain_code_point)) {
-      out = std::nullopt;
-      return false;
-    }
 #else
     (void)be_strict; // unused.
     out = input; // We cannot do much more for now.

src/url.cpp

@@ -370,6 +370,11 @@ namespace ada {
       return is_valid = false;
     }
 
+    if(std::any_of(host.value().begin(), host.value().end(), ada::unicode::is_forbidden_domain_code_point)) {
+      host = std::nullopt;
+      return is_valid = false;
+    }
+
     // If asciiDomain ends in a number, then return the result of IPv4 parsing asciiDomain.
     if(checkers::is_ipv4(host.value())) {
       ada_log("parse_host got ipv4", *host);