fix coverty issues (#907)

Author: anonrig

include/ada/implementation-inl.h

@@ -19,7 +19,7 @@ namespace ada {
 #if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 ada_warn_unused tl::expected<url_pattern<regex_provider>, errors>
-parse_url_pattern(std::variant<std::string_view, url_pattern_init> input,
+parse_url_pattern(std::variant<std::string_view, url_pattern_init>&& input,
                   const std::string_view* base_url,
                   const url_pattern_options* options) {
   return parser::parse_url_pattern_impl<regex_provider>(std::move(input),

include/ada/implementation.h

@@ -62,7 +62,7 @@ bool can_parse(std::string_view input,
  */
 template <url_pattern_regex::regex_concept regex_provider>
 ada_warn_unused tl::expected<url_pattern<regex_provider>, errors>
-parse_url_pattern(std::variant<std::string_view, url_pattern_init> input,
+parse_url_pattern(std::variant<std::string_view, url_pattern_init>&& input,
                   const std::string_view* base_url = nullptr,
                   const url_pattern_options* options = nullptr);
 #endif  // ADA_INCLUDE_URL_PATTERN

include/ada/parser-inl.h

@@ -19,7 +19,7 @@ namespace ada::parser {
 #if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 tl::expected<url_pattern<regex_provider>, errors> parse_url_pattern_impl(
-    std::variant<std::string_view, url_pattern_init> input,
+    std::variant<std::string_view, url_pattern_init>&& input,
     const std::string_view* base_url, const url_pattern_options* options) {
   // Let init be null.
   url_pattern_init init;

include/ada/parser.h

@@ -61,7 +61,7 @@ extern template url parse_url_impl<url>(std::string_view user_input,
 #if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 tl::expected<url_pattern<regex_provider>, errors> parse_url_pattern_impl(
-    std::variant<std::string_view, url_pattern_init> input,
+    std::variant<std::string_view, url_pattern_init>&& input,
     const std::string_view* base_url, const url_pattern_options* options);
 #endif  // ADA_INCLUDE_URL_PATTERN
 

include/ada/url_aggregator.h

@@ -228,9 +228,9 @@ struct url_aggregator : url_base {
   // url_pattern methods
   template <url_pattern_regex::regex_concept regex_provider>
   friend tl::expected<url_pattern<regex_provider>, errors>
-  parse_url_pattern_impl(std::variant<std::string_view, url_pattern_init> input,
-                         const std::string_view *base_url,
-                         const url_pattern_options *options);
+  parse_url_pattern_impl(
+      std::variant<std::string_view, url_pattern_init> &&input,
+      const std::string_view *base_url, const url_pattern_options *options);
 #endif  // ADA_INCLUDE_URL_PATTERN
 
   std::string buffer{};

include/ada/url_pattern.h

@@ -55,17 +55,17 @@ class url_pattern_part {
  public:
   url_pattern_part(url_pattern_part_type _type, std::string&& _value,
                    url_pattern_part_modifier _modifier)
-      : type(_type), value(_value), modifier(_modifier) {}
+      : type(_type), value(std::move(_value)), modifier(_modifier) {}
 
   url_pattern_part(url_pattern_part_type _type, std::string&& _value,
                    url_pattern_part_modifier _modifier, std::string&& _name,
                    std::string&& _prefix, std::string&& _suffix)
       : type(_type),
-        value(_value),
+        value(std::move(_value)),
         modifier(_modifier),
-        name(_name),
-        prefix(_prefix),
-        suffix(_suffix) {}
+        name(std::move(_name)),
+        prefix(std::move(_prefix)),
+        suffix(std::move(_suffix)) {}
   // A part has an associated type, a string, which must be set upon creation.
   url_pattern_part_type type;
   // A part has an associated value, a string, which must be set upon creation.
@@ -159,7 +159,7 @@ class url_pattern_component {
                         bool new_has_regexp_groups)
       : regexp(std::move(new_regexp)),
         pattern(std::move(new_pattern)),
-        group_name_list(new_group_name_list),
+        group_name_list(std::move(new_group_name_list)),
         has_regexp_groups(new_has_regexp_groups) {}
 
   // @see https://urlpattern.spec.whatwg.org/#compile-a-component
@@ -295,7 +295,7 @@ class url_pattern {
 
   template <url_pattern_regex::regex_concept P>
   friend tl::expected<url_pattern<P>, errors> parser::parse_url_pattern_impl(
-      std::variant<std::string_view, url_pattern_init> input,
+      std::variant<std::string_view, url_pattern_init>&& input,
       const std::string_view* base_url, const url_pattern_options* options);
 
   /**

include/ada/url_pattern_init.h

@@ -42,7 +42,7 @@ struct url_pattern_init {
   // All strings must be valid UTF-8.
   // @see https://urlpattern.spec.whatwg.org/#process-a-urlpatterninit
   static tl::expected<url_pattern_init, errors> process(
-      url_pattern_init init, process_type type,
+      const url_pattern_init& init, process_type type,
       std::optional<std::string_view> protocol = std::nullopt,
       std::optional<std::string_view> username = std::nullopt,
       std::optional<std::string_view> password = std::nullopt,

src/url_pattern.cpp

@@ -9,7 +9,7 @@
 namespace ada {
 
 tl::expected<url_pattern_init, errors> url_pattern_init::process(
-    url_pattern_init init, url_pattern_init::process_type type,
+    const url_pattern_init& init, url_pattern_init::process_type type,
     std::optional<std::string_view> protocol,
     std::optional<std::string_view> username,
     std::optional<std::string_view> password,