test: add more edge cases

Author: anonrig

src/url-setters.cpp

@@ -50,11 +50,13 @@ namespace ada {
   void url::set_search(const std::string_view input) {
     if (input.empty()) {
       query = std::nullopt;
-      if (has_opaque_path) {
-        size_t non_whitespace_location = path.find_first_of(' ');
-        if (non_whitespace_location != std::string_view::npos) {
-          path = path.substr(0, non_whitespace_location);
-        }
+
+      // Potentially strip trailing spaces from an opaque path
+      if (!has_opaque_path || fragment.has_value()) return;
+
+      size_t non_whitespace_location = path.find_first_of(' ');
+      if (non_whitespace_location != std::string_view::npos) {
+        path = path.substr(0, non_whitespace_location);
       }
       return;
     }

tests/basic_tests.cpp

@@ -150,14 +150,26 @@ bool nodejs2() {
   TEST_SUCCEED()
 }
 
+bool nodejs3() {
+  TEST_START()
+  auto url = ada::parse("data:space    ?test#test");
+  TEST_ASSERT(url->get_search(), "?test", "search is not equal");
+  url->set_search("");
+  TEST_ASSERT(url->get_search(), "", "search should have been empty");
+  TEST_ASSERT(url->get_pathname(), "space    ", "pathname should have been 'space' without trailing spaces");
+  TEST_ASSERT(url->get_href(), "data:space    #test", "href is not equal");
+  TEST_SUCCEED()
+}
+
 int main() {
     bool success = set_host_should_return_false_sometimes()
      && set_host_should_return_true_sometimes()
      && set_hostname_should_return_false_sometimes()
      && set_hostname_should_return_true_sometimes()
      && readme1() && readme2() && readme3() 
      && readme4() && readme5() && readme6()
-     && readme7() && nodejs1() && nodejs2();
+     && readme7() && nodejs1() && nodejs2()
+     && nodejs3();
     if(success) { return EXIT_SUCCESS; }
     return EXIT_FAILURE;
 }