refactor: normalize has_credentials method name (#333)

Author: anonrig

include/ada/url-inl.h

@@ -16,8 +16,7 @@
 #endif  // ADA_REGULAR_VISUAL_STUDIO
 
 namespace ada {
-[[nodiscard]] ada_really_inline bool url::includes_credentials()
-    const noexcept {
+[[nodiscard]] ada_really_inline bool url::has_credentials() const noexcept {
   return !username.empty() || !password.empty();
 }
 [[nodiscard]] inline bool url::cannot_have_credentials_or_port() const {
@@ -53,7 +52,7 @@ size_t url::get_pathname_length() const noexcept { return path.size(); }
     // 2 characters for "//" and 1 character for starting index
     out.host_start = out.protocol_end + 2;
 
-    if (includes_credentials()) {
+    if (has_credentials()) {
       out.username_end = uint32_t(out.host_start + username.size());
 
       out.host_start += uint32_t(username.size());
@@ -181,7 +180,7 @@ inline void url::copy_scheme(const ada::url &u) {
 
   if (host.has_value()) {
     output += "//";
-    if (includes_credentials()) {
+    if (has_credentials()) {
       output += username;
       if (!password.empty()) {
         output += ":" + get_password();

include/ada/url.h

@@ -323,7 +323,7 @@ struct url : url_base {
    * A URL includes credentials if its username or password is not the empty
    * string.
    */
-  [[nodiscard]] ada_really_inline bool includes_credentials() const noexcept;
+  [[nodiscard]] ada_really_inline bool has_credentials() const noexcept;
 
   /**
    * @private

include/ada/url_aggregator-inl.h

@@ -716,8 +716,8 @@ inline bool url_aggregator::base_search_has_value() const {
   return components.search_start != url_components::omitted;
 }
 
-ada_really_inline bool url_aggregator::includes_credentials() const noexcept {
-  ada_log("url_aggregator::includes_credentials");
+ada_really_inline bool url_aggregator::has_credentials() const noexcept {
+  ada_log("url_aggregator::has_credentials");
   return has_non_empty_username() || has_non_empty_password();
 }
 

include/ada/url_aggregator.h

@@ -156,7 +156,7 @@ struct url_aggregator : url_base {
    * A URL includes credentials if its username or password is not the empty
    * string.
    */
-  [[nodiscard]] ada_really_inline bool includes_credentials() const noexcept;
+  [[nodiscard]] ada_really_inline bool has_credentials() const noexcept;
 
   /**
    * @private

src/url-setters.cpp

@@ -50,7 +50,7 @@ bool url::set_host_or_hostname(const std::string_view input) {
     // empty string, and either url includes credentials or url’s port is
     // non-null, return.
     else if (host_view.empty() &&
-             (is_special() || includes_credentials() || port.has_value())) {
+             (is_special() || has_credentials() || port.has_value())) {
       return false;
     }
 

src/url.cpp

@@ -342,7 +342,7 @@ ada_really_inline bool url::parse_scheme(const std::string_view input) {
 
       // If url includes credentials or has a non-null port, and buffer is
       // "file", then return.
-      if ((includes_credentials() || port.has_value()) &&
+      if ((has_credentials() || port.has_value()) &&
           parsed_type == ada::scheme::type::FILE) {
         return true;
       }
@@ -387,7 +387,7 @@ ada_really_inline bool url::parse_scheme(const std::string_view input) {
 
       // If url includes credentials or has a non-null port, and buffer is
       // "file", then return.
-      if ((includes_credentials() || port.has_value()) && _buffer == "file") {
+      if ((has_credentials() || port.has_value()) && _buffer == "file") {
         return true;
       }
 
@@ -539,7 +539,7 @@ std::string url::to_string() const {
   answer.append("\t\"protocol\":\"");
   helpers::encode_json(get_protocol(), back);
   answer.append("\",\n");
-  if (includes_credentials()) {
+  if (has_credentials()) {
     answer.append("\t\"username\":\"");
     helpers::encode_json(username, back);
     answer.append("\",\n");

src/url_aggregator.cpp

@@ -38,8 +38,7 @@ template <bool has_state_override>
 
       // If url includes credentials or has a non-null port, and buffer is
       // "file", then return.
-      if ((includes_credentials() ||
-           components.port != url_components::omitted) &&
+      if ((has_credentials() || components.port != url_components::omitted) &&
           parsed_type == ada::scheme::type::FILE) {
         return true;
       }
@@ -82,8 +81,7 @@ template <bool has_state_override>
 
       // If url includes credentials or has a non-null port, and buffer is
       // "file", then return.
-      if ((includes_credentials() ||
-           components.port != url_components::omitted) &&
+      if ((has_credentials() || components.port != url_components::omitted) &&
           _buffer == "file") {
         return true;
       }
@@ -570,7 +568,7 @@ bool url_aggregator::set_host_or_hostname(const std::string_view input) {
     // empty string, and either url includes credentials or url’s port is
     // non-null, return.
     else if (host_view.empty() &&
-             (is_special() || includes_credentials() ||
+             (is_special() || has_credentials() ||
               components.port != url_components::omitted)) {
       return false;
     }
@@ -783,7 +781,7 @@ std::string ada::url_aggregator::to_string() const {
   helpers::encode_json(get_protocol(), back);
   answer.append("\",\n");
 
-  if (includes_credentials()) {
+  if (has_credentials()) {
     answer.append("\t\"username\":\"");
     helpers::encode_json(get_username(), back);
     answer.append("\",\n");

tests/url_components.cpp

@@ -149,7 +149,7 @@ bool urltestdata_encoding(const char* source) {
         }
 
         size_t host_start = out.host_start;
-        if (url.includes_credentials()) {
+        if (url.has_credentials()) {
           TEST_ASSERT(url.get_href()[out.host_start], '@',
                       "hostname should start with @");
           host_start++;