fix: bad usage of std::string_view::npos

Co-authored-by: codebytere <shelley.vohr@gmail.com>

Author: 2 people

include/ada/helpers.h

@@ -82,8 +82,8 @@ ada_really_inline void remove_ascii_tab_or_newline(std::string& input) noexcept;
 
 /**
  * @private
- * Return the substring from input going from index pos to the end. If pos >
- * input.size(), it returns an empty string_view. This function cannot throw.
+ * Return the substring from input going from index pos to the end.
+ * This function cannot throw.
  */
 ada_really_inline std::string_view substring(std::string_view input,
                                              size_t pos) noexcept;

src/helpers.cpp

@@ -106,9 +106,9 @@ ada_really_inline bool shorten_path(std::string& path,
   // If url’s scheme is "file", path’s size is 1, and path[0] is a normalized
   // Windows drive letter, then return.
   if (type == ada::scheme::type::FILE &&
-      first_delimiter == std::string_view::npos) {
+      first_delimiter == std::string_view::npos && !path.empty()) {
     if (checkers::is_normalized_windows_drive_letter(
-            std::string_view(path.data() + 1, first_delimiter - 1))) {
+            helpers::substring(path, 1))) {
       return false;
     }
   }
@@ -130,9 +130,9 @@ ada_really_inline bool shorten_path(std::string_view& path,
   // If url’s scheme is "file", path’s size is 1, and path[0] is a normalized
   // Windows drive letter, then return.
   if (type == ada::scheme::type::FILE &&
-      first_delimiter == std::string_view::npos) {
+      first_delimiter == std::string_view::npos && !path.empty()) {
     if (checkers::is_normalized_windows_drive_letter(
-            std::string_view(path.data() + 1, first_delimiter - 1))) {
+            helpers::substring(path, 1))) {
       return false;
     }
   }