Extract setChroot helper to reduce duplication in PHPRequestHandler

Author: adamziel

packages/php-wasm/universal/src/lib/php-request-handler.ts

@@ -206,9 +206,7 @@ export class PHPRequestHandler implements AsyncDisposable {
 			getFileNotFoundAction = () => ({ type: '404' }),
 		} = config;
 
-		if ('php' in config) {
-			const php = config.php;
-
+		const setChroot = (php: PHP) => {
 			// Always set managed PHP's cwd to the document root.
 			if (!php.isDir(documentRoot)) {
 				php.mkdir(documentRoot);
@@ -217,24 +215,21 @@ export class PHPRequestHandler implements AsyncDisposable {
 
 			// @TODO: Decouple PHP and request handler
 			(php as any).requestHandler = this;
+		};
 
-			this.processManager = new SinglePHPInstanceManager({ php });
+		if ('php' in config) {
+			setChroot(config.php);
+			this.processManager = new SinglePHPInstanceManager({
+				php: config.php,
+			});
 		} else {
 			this.processManager = new PHPProcessManager({
 				phpFactory: async (info) => {
 					const php = await config.phpFactory({
 						...info,
 						requestHandler: this,
 					});
-
-					// Always set managed PHP's cwd to the document root.
-					if (!php.isDir(documentRoot)) {
-						php.mkdir(documentRoot);
-					}
-					php.chdir(documentRoot);
-
-					// @TODO: Decouple PHP and request handler
-					(php as any).requestHandler = this;
+					setChroot(php);
 					return php;
 				},
 				maxPhpInstances: config.maxPhpInstances,