Initial PeopleAPI tests

Author: cmlccie

tests/api/test_memberships.py

@@ -206,7 +206,7 @@ def test_update_membership_make_moderator(self,
         assert make_me_group_room_moderator.isModerator
 
     def test_delete_membership(self, api, group_room, test_people):
-        person = test_people["delete_membership_test_person"]
+        person = test_people["not_a_member"]
         membership = add_person_to_room_by_id(api, group_room, person)
         assert is_valid_membership(membership)
         delete_membership(api, membership)

tests/api/test_people.py

@@ -3,6 +3,8 @@
 """pytest People functions, fixtures and tests."""
 
 
+import itertools
+
 import pytest
 
 import ciscosparkapi
@@ -22,8 +24,12 @@ def get_person_by_id(api, id):
     return api.people.get(id)
 
 
+def list_people(api, **search_attribute):
+    return list(api.people.list(**search_attribute))
+
+
 def get_person_by_email(api, email):
-    list_of_people = list(api.people.list(email=email))
+    list_of_people = list_people(api, email=email)
     if list_of_people:
         # If found, there should only be one Spark account associated with an
         # single e-mail address.
@@ -37,6 +43,10 @@ def create_person(api, emails, **person_attributes):
     return api.people.create(emails, **person_attributes)
 
 
+def update_person(api, person, **person_attributes):
+    return api.people.update(person.id, **person_attributes)
+
+
 def delete_person(api, person):
     api.people.delete(person.id)
 
@@ -83,11 +93,15 @@ def __getitem__(self, item):
             self.test_people[item] = new_test_person
             return new_test_person
 
+    @property
     def list(self):
         return self.test_people.values()
 
+    def len(self):
+        return len(self.list)
+
     def __iter__(self):
-        return iter(self.list())
+        return iter(self.list)
 
     def __del__(self):
         for person in self.test_people.values():
@@ -104,14 +118,14 @@ def me(api):
 
 @pytest.fixture(scope="session")
 def test_people(api, get_new_email_address, licenses_dict):
-    test_people = TestPeople()
+    test_people = TestPeople(api, get_new_email_address, licenses_dict)
     yield test_people
-    del(test_people)
+    del test_people
 
 
 @pytest.fixture()
 def temp_person(api, get_new_email_address, licenses_dict):
-    person =  get_new_test_person(api, get_new_email_address, licenses_dict)
+    person = get_new_test_person(api, get_new_email_address, licenses_dict)
     yield person
     delete_person(api, person)
 
@@ -120,3 +134,58 @@ def temp_person(api, get_new_email_address, licenses_dict):
 def people_in_group_room(api, group_room_memberships):
     return [get_person_by_id(api, membership.personId)
             for membership in group_room_memberships]
+
+
+# Tests
+
+class TestPeopleAPI(object):
+    """Test PeopleAPI methods."""
+
+    def test_create_person(self, test_people):
+        person = test_people["not_a_member"]
+        assert is_valid_person(person)
+
+    def test_update_person(self, api, test_people):
+        person = test_people["not_a_member"]
+        # TODO: Verify attributes that can be updated
+        updated_attributes = {
+            "displayName": person.displayName + " Updated",
+            "firstName": person.firstName + " Updated",
+            "lastName": person.lastName + " Updated",
+        }
+        updated_person = update_person(api, person, **updated_attributes)
+        assert is_valid_person(updated_person)
+        for attribute, value in updated_attributes:
+            assert getattr(updated_person, attribute, default=None) == value
+
+    def test_get_my_details(self, me):
+        assert is_valid_person(me)
+
+    def test_get_person_details(self, api, test_people):
+        person_id = test_people["not_a_member"].id
+        person = get_person_by_id(api, person_id)
+        assert is_valid_person(person)
+
+    def test_list_people_by_email(self, api, test_people):
+        email = test_people["not_a_member"].emails[0]
+        list_of_people = list_people(api, email=email)
+        assert len(list_of_people) >= 1
+        assert are_valid_people(list_of_people)
+
+    def test_list_people_by_display_name(self, api, test_people):
+        display_name = test_people["not_a_member"].displayName
+        list_of_people = list_people(api, displayName=display_name)
+        assert len(list_of_people) >= 1
+        assert are_valid_people(list_of_people)
+
+    def test_list_people_with_paging(self, api, test_people,
+                                     additional_group_room_memberships):
+        page_size = 1
+        pages = 3
+        num_people = pages * page_size
+        assert len(test_people) >= num_people
+        display_name = test_people["not_a_member"].displayName
+        people = api.people.list(displayName=display_name, max=page_size)
+        people_list = list(itertools.islice(people, num_people))
+        assert len(people_list) == num_people
+        assert are_valid_people(people_list)

tests/api/test_teammemberships.py

@@ -193,7 +193,7 @@ def test_update_membership_make_moderator(self,
         assert make_me_team_moderator.isModerator
 
     def test_delete_membership(self, api, team, test_people):
-        person = test_people["delete_membership_test_person"]
+        person = test_people["not_a_member"]
         membership = add_person_to_team_by_id(api, team, person)
         assert is_valid_membership(membership)
         delete_membership(api, membership)