Skip to content

Conversation

@TiaTuinstra
Copy link
Collaborator

Replaces static in-template values with those from config/map_school.json, with the goal of supporting mapping of school-specific info (i.e. satellite office contact info).
Currently, values included are: "phu_address", "phu_phone", "phu_email", "phu_website"
"DEFAULT" section must be present in mapping file with all required keys. These defaults are used when a key is not present for "SCHOOL_NAME" in the mapping .json file.

…tain 'DEFAULT' key with all required school/phu-specific template arguments; pulled from new main branch
… default, build_template_context function in generate_notices.py will expect and read from config/map_school.json.
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pipeline/generate_notices.py 84.61% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@TiaTuinstra TiaTuinstra marked this pull request as ready for review November 6, 2025 18:55
@jangevaare
Copy link
Member

Couple early thoughts:

Could we make school ID a required field for data inputs to support matching like this? Sometimes school names are not guaranteed to be unique.

Alternatively, we could consider having a client/row-specific notice version identifier, rather than using a school mapping within the pipeline. That way whatever mapping is desired could be done on the client level and outside the pipeline

@TiaTuinstra
Copy link
Collaborator Author

TiaTuinstra commented Nov 7, 2025

Thoughts much appreciated!

Could we make school ID a required field for data inputs to support matching like this? Sometimes school names are not guaranteed to be unique.

Is school ID a usual way of distinguishing schools within health authorities / are these school IDs present in the Panorama data?
I remember before the refactor seeing that batches were named by SCHOOL_NAME and batch number, did we have a different method there too of addressing duplicate school names?

Alternatively, we could consider having a client/row-specific notice version identifier, rather than using a school mapping within the pipeline. That way whatever mapping is desired could be done on the client level and outside the pipeline

That would be interesting! And definitely allow for a cleaner pipeline if all of the filtering/grouping could be separated out - will explore more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow for mapping schools to specific satellite offices for support

3 participants