-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/map schools #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/map schools #80
Conversation
…d; added pretty-json to pre-commit linting
…tain 'DEFAULT' key with all required school/phu-specific template arguments; pulled from new main branch
… default, build_template_context function in generate_notices.py will expect and read from config/map_school.json.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Couple early thoughts: Could we make school ID a required field for data inputs to support matching like this? Sometimes school names are not guaranteed to be unique. Alternatively, we could consider having a client/row-specific notice version identifier, rather than using a school mapping within the pipeline. That way whatever mapping is desired could be done on the client level and outside the pipeline |
|
Thoughts much appreciated!
Is school ID a usual way of distinguishing schools within health authorities / are these school IDs present in the Panorama data?
That would be interesting! And definitely allow for a cleaner pipeline if all of the filtering/grouping could be separated out - will explore more |
Replaces static in-template values with those from config/map_school.json, with the goal of supporting mapping of school-specific info (i.e. satellite office contact info).
Currently, values included are: "phu_address", "phu_phone", "phu_email", "phu_website"
"DEFAULT" section must be present in mapping file with all required keys. These defaults are used when a key is not present for "SCHOOL_NAME" in the mapping .json file.