Skip to content

Fix and adjust alert margins #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hans5958 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix and adjust alert margins #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94424d5
Force create paragraph on Prettier
Hans5958 Dec 27, 2025
8c8a937
Reduce margin between alert title and desc
Hans5958 Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/ui/alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const AlertTitle = React.forwardRef<
>(({ className, ...props }, ref) => (
<p
ref={ref}
className={cn("mb-1 font-semibold leading-none", className)}
className={cn("my-3 mt-5 font-semibold leading-none", className)}
{...props}
/>
));
Expand All @@ -54,7 +54,10 @@ const AlertDescription = React.forwardRef<
>(({ className, ...props }, ref) => (
<div
ref={ref}
className={cn("[&_p]:leading-relaxed", className)}
className={cn(
"mb-5 [&>:first-child]:mt-0 [&_p]:leading-relaxed",
className,
)}
{...props}
/>
));
Expand Down
20 changes: 16 additions & 4 deletions src/content/rules/prioritize-official-translations.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,25 @@ Note that alternative names can be put as an alias of an entry.
For "[Servant of Evil](https://vocadb.net/S/1358)", despite the more known "Servant of Evil" title, the official translation, "His significance of existence", should be used as the primary name.

<BoxGroup>
<Alert variant="incorrect">**English**: Servant of Evil</Alert>
<Alert variant="correct">**English**: His significance of existence</Alert>
<Alert variant="incorrect">
<></>
**English**: Servant of Evil
</Alert>
<Alert variant="correct">
<></>
**English**: His significance of existence
</Alert>
</BoxGroup>

For "[DUNE](https://vocadb.net/S/157860)", although the transliteration "Sand Planet" is popular, the official translation, "DUNE", should be used as the primary name.

<BoxGroup>
<Alert variant="incorrect">**English**: Sand Planet</Alert>
<Alert variant="correct">**English**: DUNE</Alert>
<Alert variant="incorrect">
<></>
**English**: Sand Planet
</Alert>
<Alert variant="correct">
<></>
**English**: DUNE
</Alert>
</BoxGroup>