Ignore inherit param for ParameterInfo.GetCustomAttributes

bholmes · bholmes · commit 2ddd35a9d0d1 · 2021-08-23T11:45:15.000-04:00
It is documented that the inherit flag is ignored.
Attribute.GetCustomAttributes is to be used to search
inheritance chain.

This change is only for the Mono classlib implementation.
CoreCLR already has this behavior.
diff --git a/mcs/class/corlib/System.Reflection/RuntimeParameterInfo.cs b/mcs/class/corlib/System.Reflection/RuntimeParameterInfo.cs
@@ -192,14 +192,20 @@ int MetadataToken {
 		override
 		object[] GetCustomAttributes (bool inherit)
 		{
-			return MonoCustomAttrs.GetCustomAttributes (this, inherit);
+			// It is documented that the inherit flag is ignored.
+			// Attribute.GetCustomAttributes is to be used to search
+			// inheritance chain.
+			return MonoCustomAttrs.GetCustomAttributes (this, false);
 		}
 
 		public
 		override
 		object[] GetCustomAttributes (Type attributeType, bool inherit)
 		{
-			return MonoCustomAttrs.GetCustomAttributes (this, attributeType, inherit);
+			// It is documented that the inherit flag is ignored.
+			// Attribute.GetCustomAttributes is to be used to search
+			// inheritance chain.
+			return MonoCustomAttrs.GetCustomAttributes (this, attributeType, false);
 		}
 
 		internal object GetDefaultValueImpl (ParameterInfo pinfo)

Original file line number	Diff line number	Diff line change
`@@ -192,14 +192,20 @@ int MetadataToken {`
`192`	`192`	`override`
`193`	`193`	`object[] GetCustomAttributes (bool inherit)`
`194`	`194`	`{`
`195`		`- return MonoCustomAttrs.GetCustomAttributes (this, inherit);`
	`195`	`+ // It is documented that the inherit flag is ignored.`
	`196`	`+ // Attribute.GetCustomAttributes is to be used to search`
	`197`	`+ // inheritance chain.`
	`198`	`+ return MonoCustomAttrs.GetCustomAttributes (this, false);`
`196`	`199`	`}`
`197`	`200`
`198`	`201`	`public`
`199`	`202`	`override`
`200`	`203`	`object[] GetCustomAttributes (Type attributeType, bool inherit)`
`201`	`204`	`{`
`202`		`- return MonoCustomAttrs.GetCustomAttributes (this, attributeType, inherit);`
	`205`	`+ // It is documented that the inherit flag is ignored.`
	`206`	`+ // Attribute.GetCustomAttributes is to be used to search`
	`207`	`+ // inheritance chain.`
	`208`	`+ return MonoCustomAttrs.GetCustomAttributes (this, attributeType, false);`
`203`	`209`	`}`
`204`	`210`
`205`	`211`	`internal object GetDefaultValueImpl (ParameterInfo pinfo)`