fix: mono cecil compatibility and UNET removal fixes for 2022.2.0a13 and above (#2000)

Author: ShadauxCat

com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs

@@ -609,17 +609,19 @@ private MethodReference GetFastBufferWriterWriteMethod(string name, TypeReferenc
                             {
 #if CECIL_CONSTRAINTS_ARE_TYPE_REFERENCES
                                 var resolvedConstraint = constraint.Resolve();
+                                var constraintTypeRef = constraint;
 #else
                                 var resolvedConstraint = constraint.ConstraintType.Resolve();
+                                var constraintTypeRef = constraint.ConstraintType;
 #endif
 
                                 var resolvedConstraintName = resolvedConstraint.FullNameWithGenericParameters(new[] { method.GenericParameters[0] }, new[] { checkType });
-                                if (constraint.IsGenericInstance)
+                                if (constraintTypeRef.IsGenericInstance)
                                 {
-                                    var genericConstraint = (GenericInstanceType)constraint;
+                                    var genericConstraint = (GenericInstanceType)constraintTypeRef;
                                     if (genericConstraint.HasGenericArguments && genericConstraint.GenericArguments[0].Resolve() != null)
                                     {
-                                        resolvedConstraintName = constraint.FullName;
+                                        resolvedConstraintName = constraintTypeRef.FullName;
                                     }
                                 }
                                 if ((resolvedConstraint.IsInterface && !checkType.HasInterface(resolvedConstraintName)) ||
@@ -751,18 +753,20 @@ private MethodReference GetFastBufferReaderReadMethod(string name, TypeReference
                             {
 #if CECIL_CONSTRAINTS_ARE_TYPE_REFERENCES
                                 var resolvedConstraint = constraint.Resolve();
+                                var constraintTypeRef = constraint;
 #else
                                 var resolvedConstraint = constraint.ConstraintType.Resolve();
+                                var constraintTypeRef = constraint.ConstraintType;
 #endif
 
 
                                 var resolvedConstraintName = resolvedConstraint.FullNameWithGenericParameters(new[] { method.GenericParameters[0] }, new[] { checkType });
-                                if (constraint.IsGenericInstance)
+                                if (constraintTypeRef.IsGenericInstance)
                                 {
-                                    var genericConstraint = (GenericInstanceType)constraint;
+                                    var genericConstraint = (GenericInstanceType)constraintTypeRef;
                                     if (genericConstraint.HasGenericArguments && genericConstraint.GenericArguments[0].Resolve() != null)
                                     {
-                                        resolvedConstraintName = constraint.FullName;
+                                        resolvedConstraintName = constraintTypeRef.FullName;
                                     }
                                 }
 

testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs

@@ -5,7 +5,9 @@
 using UnityEngine.SceneManagement;
 using UnityEngine.TestTools;
 using Object = UnityEngine.Object;
+#if UNITY_UNET_PRESENT
 using Unity.Netcode.Transports.UNET;
+#endif
 using Unity.Netcode.Transports.UTP;
 
 
@@ -84,13 +86,15 @@ private void OnSceneLoaded(Scene scene, LoadSceneMode mode)
             MultiprocessLogger.Log($"transport is {transport}");
             switch (transport)
             {
+#if UNITY_UNET_PRESENT
                 case UNetTransport unetTransport:
                     unetTransport.ConnectPort = int.Parse(TestCoordinator.Port);
                     unetTransport.ServerListenPort = int.Parse(TestCoordinator.Port);
                     unetTransport.ConnectAddress = "127.0.0.1";
                     MultiprocessLogger.Log($"Setting ConnectAddress to {unetTransport.ConnectAddress} port {unetTransport.ConnectPort}, {unetTransport.ServerListenPort}");
 
                     break;
+#endif
                 case UnityTransport unityTransport:
                     unityTransport.ConnectionData.ServerListenAddress = "0.0.0.0";
                     MultiprocessLogger.Log($"Setting unityTransport.ConnectionData.Port {unityTransport.ConnectionData.ServerListenAddress}");

testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs

@@ -7,7 +7,9 @@
 using NUnit.Framework;
 using UnityEngine;
 using Unity.Netcode.MultiprocessRuntimeTests;
+#if UNITY_UNET_PRESENT
 using Unity.Netcode.Transports.UNET;
+#endif
 using Unity.Netcode.Transports.UTP;
 
 /// <summary>
@@ -156,6 +158,7 @@ private void SetAddressAndPort()
         MultiprocessLogger.Log($"transport is {transport}");
         switch (transport)
         {
+#if UNITY_UNET_PRESENT
             case UNetTransport unetTransport:
                 unetTransport.ConnectPort = ushortport;
                 unetTransport.ServerListenPort = ushortport;
@@ -165,6 +168,7 @@ private void SetAddressAndPort()
                     unetTransport.ConnectAddress = m_ConnectAddress;
                 }
                 break;
+#endif
             case UnityTransport unityTransport:
                 MultiprocessLogger.Log($"Setting unityTransport.ConnectionData.Port {ushortport}, isClient: {m_IsClient}, Address {m_ConnectAddress}");
                 unityTransport.ConnectionData.Port = ushortport;