fix: Incorrect spawn object sent metrics (#1298)

* Only track objects spawned when a message is sent
* Track player object spawn when new player joins
* fix failing test

Author: Josie Messa

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -1610,7 +1610,8 @@ internal void ApprovedPlayerSpawn(ulong clientId, uint playerPrefabHash)
                 message.ObjectInfo.Header.HasParent = false;
                 message.ObjectInfo.Header.IsPlayerObject = true;
                 message.ObjectInfo.Header.OwnerClientId = clientId;
-                SendMessage(message, NetworkDelivery.ReliableFragmentedSequenced, clientPair.Key);
+                var size = SendMessage(message, NetworkDelivery.ReliableFragmentedSequenced, clientPair.Key);
+                NetworkMetrics.TrackObjectSpawnSent(clientPair.Key, ConnectedClients[clientId].PlayerObject, size);
             }
         }
     }

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -439,8 +439,6 @@ private void SpawnNetworkObjectLocallyCommon(NetworkObject networkObject, ulong
             SpawnedObjects.Add(networkObject.NetworkObjectId, networkObject);
             SpawnedObjectsList.Add(networkObject);
 
-            NetworkManager.NetworkMetrics.TrackObjectSpawnSent(NetworkManager.LocalClientId, networkObject, 0);
-
             if (ownerClientId != null)
             {
                 if (NetworkManager.IsServer)

com.unity.netcode.gameobjects/Tests/Runtime/Metrics/NetworkObjectMetricsTests.cs

@@ -51,7 +51,7 @@ public IEnumerator TrackNetworkObjectSpawnSentMetric()
             yield return waitForMetricEvent.WaitForMetricsReceived();
 
             var objectSpawnedSentMetricValues = waitForMetricEvent.AssertMetricValuesHaveBeenFound();
-            Assert.AreEqual(2, objectSpawnedSentMetricValues.Count);
+            Assert.AreEqual(1, objectSpawnedSentMetricValues.Count);
 
             var objectSpawned = objectSpawnedSentMetricValues.Last();
             Assert.AreEqual(Client.LocalClientId, objectSpawned.Connection.Id);