fix: NetworkTransform authority warning [MTT-1291] (#1846)

* fix

enabling the NetworkTransform debug information.

* test

This verifies the authority warning is working on the client side.

* style

MTT-1291
Added some additional comments and making sure this branch is tracked in the task.

* update

Added Unity.Netcode.Components to test project's runtime assembly so we can write tests for the components in this test assembly.

* style

white space removal

* update

only need to check for isRotationDirty as this is only set when any of the SyncRotAngle[xyz] are set to true.

* style

* update

Fixes the issue where there was no minimum threshold value which meant a user could set the threshold to zero which would cause non-authoritative false-positive warnings.
Fixes the issue where NetworkRigidBody was only setting IsKinematic to true when the NetworkObject was spawned which could cause non-authoritative false-positive warnings.
Fixes the issue where the very next frame update after OnNetworkSpawn could cause non-authoritative false-positive warnings.
Fixes the issue where changing the parent could cause non-authoritative false-positive warnings.
Fixes the issue where rotation was improperly checking for a delta rotation that was larger than the rotation threshold.

* style

removing commented out code

* style

updating an removing some comments.

* update

Fixing some issues Fatih caught.
Refactoring when we have to delay for the authority check.  It is only needed when the parent changes.
Removing data size spam messages when LogLevel.Developer.
Adding scale and rotation to the test as well as verification that there is no notification when below the threshold.

* style

* update

Adding warning message when any threshold is below the minimum threshold value during OnValidate.

* Update CHANGELOG.md

* Update CHANGELOG.md

* fix

fixing some merge issues.

* update

removing authority warning related code.

* update

removing components reference since it is no longer needed.

* update

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

@@ -284,8 +284,6 @@ public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReade
 
         private NetworkTransformState m_LocalAuthoritativeNetworkState;
 
-        private NetworkTransformState m_PrevNetworkState;
-
         private const int k_DebugDrawLineTime = 10;
 
         private bool m_HasSentLastValue = false; // used to send one last value, so clients can make the difference between lost replication data (clients extrapolate) and no more data to send.
@@ -523,8 +521,6 @@ internal bool ApplyTransformToNetworkState(ref NetworkTransformState networkStat
 
         private void ApplyInterpolatedNetworkStateToTransform(NetworkTransformState networkState, Transform transformToUpdate)
         {
-            m_PrevNetworkState = networkState;
-
             var interpolatedPosition = InLocalSpace ? transformToUpdate.localPosition : transformToUpdate.position;
 
             // todo: we should store network state w/ quats vs. euler angles
@@ -601,8 +597,6 @@ private void ApplyInterpolatedNetworkStateToTransform(NetworkTransformState netw
                 {
                     transformToUpdate.position = interpolatedPosition;
                 }
-
-                m_PrevNetworkState.Position = interpolatedPosition;
             }
 
             // RotAngles Apply
@@ -616,15 +610,12 @@ private void ApplyInterpolatedNetworkStateToTransform(NetworkTransformState netw
                 {
                     transformToUpdate.rotation = Quaternion.Euler(interpolatedRotAngles);
                 }
-
-                m_PrevNetworkState.Rotation = interpolatedRotAngles;
             }
 
             // Scale Apply
             if (SyncScaleX || SyncScaleY || SyncScaleZ)
             {
                 transformToUpdate.localScale = interpolatedScale;
-                m_PrevNetworkState.Scale = interpolatedScale;
             }
         }
 
@@ -893,8 +884,6 @@ protected virtual void Update()
                 {
                     TryCommitTransformToServer(m_Transform, m_CachedNetworkManager.LocalTime.Time);
                 }
-
-                m_PrevNetworkState = m_LocalAuthoritativeNetworkState;
             }
 
             // apply interpolated value
@@ -918,36 +907,10 @@ protected virtual void Update()
 
                 if (!CanCommitToTransform)
                 {
-#if NGO_TRANSFORM_DEBUG
-                    if (m_CachedNetworkManager.LogLevel == LogLevel.Developer)
-                    {
-                        // TODO: This should be a component gizmo - not some debug draw based on log level
-                        var interpolatedPosition = new Vector3(m_PositionXInterpolator.GetInterpolatedValue(), m_PositionYInterpolator.GetInterpolatedValue(), m_PositionZInterpolator.GetInterpolatedValue());
-                        Debug.DrawLine(interpolatedPosition, interpolatedPosition + Vector3.up, Color.magenta, k_DebugDrawLineTime, false);
-
-                        // try to update previously consumed NetworkState
-                        // if we have any changes, that means made some updates locally
-                        // we apply the latest ReplNetworkState again to revert our changes
-                        var oldStateDirtyInfo = ApplyTransformToNetworkStateWithInfo(ref m_PrevNetworkState, 0, m_Transform);
-
-                        // there are several bugs in this code, as we the message is dumped out under odd circumstances
-                        //  For Matt, it would trigger when an object's rotation was perturbed by colliding with another
-                        //  object vs. explicitly rotating it
-                        if (oldStateDirtyInfo.isPositionDirty || oldStateDirtyInfo.isScaleDirty || (oldStateDirtyInfo.isRotationDirty && SyncRotAngleX && SyncRotAngleY && SyncRotAngleZ))
-                        {
-                            // ignoring rotation dirty since quaternions will mess with euler angles, making this impossible to determine if the change to a single axis comes
-                            // from an unauthorized transform change or euler to quaternion conversion artifacts.
-                            var dirtyField = oldStateDirtyInfo.isPositionDirty ? "position" : oldStateDirtyInfo.isRotationDirty ? "rotation" : "scale";
-                            Debug.LogWarning($"A local change to {dirtyField} without authority detected, reverting back to latest interpolated network state!", this);
-                        }
-                    }
-#endif
-
                     // Apply updated interpolated value
                     ApplyInterpolatedNetworkStateToTransform(m_ReplicatedNetworkState.Value, m_Transform);
                 }
             }
-
             m_LocalAuthoritativeNetworkState.IsTeleportingNextFrame = false;
         }
 

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -1417,11 +1417,6 @@ private void HandleRawTransportPoll(NetworkEvent networkEvent, ulong clientId, A
                     break;
                 case NetworkEvent.Data:
                     {
-                        if (NetworkLog.CurrentLogLevel <= LogLevel.Developer)
-                        {
-                            NetworkLog.LogInfo($"Incoming Data From {clientId}: {payload.Count} bytes");
-                        }
-
                         clientId = TransportIdToClientId(clientId);
 
                         HandleIncomingData(clientId, payload, receiveTime);