fix: transform init in OnNetworkSpawn, network transform remove lossy… (#1294)

- Init transform OnNetworkSpawn to handle disabled object spawns
- Always sync local scale since "world" (lossy) scale is an approximation

Author: mattwalsh-unity

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

@@ -298,7 +298,6 @@ public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReade
         private int m_LastSentTick;
         private NetworkTransformState m_LastSentState;
 
-
         /// <summary>
         /// Tries updating the server authoritative transform, only if allowed.
         /// If this called server side, this will commit directly.
@@ -396,7 +395,7 @@ internal bool ApplyTransformToNetworkState(ref NetworkTransformState networkStat
         {
             var position = InLocalSpace ? transformToUse.localPosition : transformToUse.position;
             var rotAngles = InLocalSpace ? transformToUse.localEulerAngles : transformToUse.eulerAngles;
-            var scale = InLocalSpace ? transformToUse.localScale : transformToUse.lossyScale;
+            var scale = transformToUse.localScale;
             return ApplyTransformToNetworkStateWithInfo(ref networkState, dirtyTime, position, rotAngles, scale);
         }
 
@@ -510,7 +509,7 @@ private void ApplyInterpolatedNetworkStateToTransform(NetworkTransformState netw
 
             // todo: we should store network state w/ quats vs. euler angles
             var interpolatedRotAngles = InLocalSpace ? transformToUpdate.localEulerAngles : transformToUpdate.eulerAngles;
-            var interpolatedScale = InLocalSpace ? transformToUpdate.localScale : transformToUpdate.lossyScale;
+            var interpolatedScale = transformToUpdate.localScale;
 
             // InLocalSpace Read
             InLocalSpace = networkState.InLocalSpace;
@@ -599,18 +598,7 @@ private void ApplyInterpolatedNetworkStateToTransform(NetworkTransformState netw
             // Scale Apply
             if (SyncScaleX || SyncScaleY || SyncScaleZ)
             {
-                if (InLocalSpace)
-                {
-                    transformToUpdate.localScale = interpolatedScale;
-                }
-                else
-                {
-                    transformToUpdate.localScale = Vector3.one;
-                    var lossyScale = transformToUpdate.lossyScale;
-                    // todo this conversion is messing with interpolation. local scale interpolates fine, lossy scale is jittery. must investigate. MTT-1208
-                    transformToUpdate.localScale = new Vector3(interpolatedScale.x / lossyScale.x, interpolatedScale.y / lossyScale.y, interpolatedScale.z / lossyScale.z);
-                }
-
+                transformToUpdate.localScale = interpolatedScale;
                 m_PrevNetworkState.Scale = interpolatedScale;
             }
         }
@@ -679,8 +667,6 @@ private void OnNetworkStateChanged(NetworkTransformState oldState, NetworkTransf
 
         private void Awake()
         {
-            m_Transform = transform;
-
             // we only want to create our interpolators during Awake so that, when pooled, we do not create tons
             //  of gc thrash each time objects wink out and are re-used
             m_PositionXInterpolator = new BufferedLinearInterpolatorFloat();
@@ -704,6 +690,10 @@ private void Awake()
 
         public override void OnNetworkSpawn()
         {
+            // must set up m_Transform in OnNetworkSpawn because it's possible an object spawns but is disabled
+            //  and thus awake won't be called.
+            // TODO: investigate further on not sending data for something that is not enabled
+            m_Transform = transform;
             m_ReplicatedNetworkState.OnValueChanged += OnNetworkStateChanged;
 
             CanCommitToTransform = IsServer;
@@ -863,6 +853,8 @@ protected virtual void Update()
                         var oldStateDirtyInfo = ApplyTransformToNetworkStateWithInfo(ref m_PrevNetworkState, 0, m_Transform);
 
                         // there are several bugs in this code, as we the message is dumped out under odd circumstances
+                        //  For Matt, it would trigger when an object's rotation was perturbed by colliding with another
+                        //  object vs. explicitly rotating it
                         if (oldStateDirtyInfo.isPositionDirty || oldStateDirtyInfo.isScaleDirty || (oldStateDirtyInfo.isRotationDirty && SyncRotAngleX && SyncRotAngleY && SyncRotAngleZ))
                         {
                             // ignoring rotation dirty since quaternions will mess with euler angles, making this impossible to determine if the change to a single axis comes

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformTests.cs

@@ -177,6 +177,8 @@ public IEnumerator TestCantChangeTransformFromOtherSideAuthority([Values] bool t
 
             Assert.AreEqual(Vector3.zero, otherSideNetworkTransform.transform.position, "got authority error, but other side still moved!");
 #if NGO_TRANSFORM_DEBUG
+            // We are no longer emitting this warning, and we are banishing tests that rely on console output, so
+            //  needs re-implementation
             // TODO: This should be a separate test - verify 1 behavior per test
             LogAssert.Expect(LogType.Warning, new Regex(".*without authority detected.*"));
 #endif