fix: Editor NetworkBehaviour dependency check for NetworkObject not using root parent transform [MTT-2973] (#1841)

* fix

Checking for NetworkObject from the root transform down.  A child GameObject can still hold a NetworkBehaviour component if the parent of the child has a NetworkObject.

* fix - editor

Fixing issue with root transform when no GameObject exists.

* fix

Spawn manager not removing entries from ownership table

* fix

Updated the description of the fix for MTT-2973

* Update CHANGELOG.md

MTT-2974

* fix

Removing the ownership check in InvokeBehaviourOnLostOwnership because clients still need to update their table when the owner has changed to remove their ownership entry in their local ownership table.

* test

updating the integration test to check and make sure that the OwnershipToObjectsTable is having entries removed when ownership is lost.

* update

removing some debug code

* update

adding PR number

* Update CHANGELOG.md

Author: NoelStephensUnity

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -21,6 +21,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - Removed `com.unity.modules.animation`, `com.unity.modules.physics` and `com.unity.modules.physics2d` dependencies from the package (#1812)
 
 ### Fixed
+- Fixed NetworkBehaviour dependency verification check for an existing NetworkObject not searching from root parent transform relative GameObject. (#1841)
 - Fixed issue where entries were not being removed from the NetworkSpawnManager.OwnershipToObjectsTable. (#1838)
 - Fixed clarity for NetworkSceneManager client side notification when it receives a scene hash value that does not exist in its local hash table. (#1828)
 - Fixed client throws a key not found exception when it times out using UNet or UTP. (#1821)

com.unity.netcode.gameobjects/Editor/NetworkBehaviourEditor.cs

@@ -225,6 +225,15 @@ private void OnEnable()
 
         internal const string AutoAddNetworkObjectIfNoneExists = "AutoAdd-NetworkObject-When-None-Exist";
 
+        public static Transform GetRootParentTransform(Transform transform)
+        {
+            if (transform.parent == null || transform.parent == transform)
+            {
+                return transform;
+            }
+            return GetRootParentTransform(transform.parent);
+        }
+
         /// <summary>
         /// Used to determine if a GameObject has one or more NetworkBehaviours but
         /// does not already have a NetworkObject component.  If not it will notify
@@ -233,17 +242,20 @@ private void OnEnable()
         public static void CheckForNetworkObject(GameObject gameObject, bool networkObjectRemoved = false)
         {
             // If there are no NetworkBehaviours or no gameObject, then exit early
-            if (gameObject == null || gameObject.GetComponent<NetworkBehaviour>() == null && gameObject.GetComponentInChildren<NetworkBehaviour>() == null)
+            if (gameObject == null || (gameObject.GetComponent<NetworkBehaviour>() == null && gameObject.GetComponentInChildren<NetworkBehaviour>() == null))
             {
                 return;
             }
 
-            // Otherwise, check to see if there is a NetworkObject and if not notify the user that NetworkBehaviours
-            // require that the relative GameObject has a NetworkObject component.
-            var networkObject = gameObject.GetComponent<NetworkObject>();
+            // Now get the root parent transform to the current GameObject (or itself)
+            var rootTransform = GetRootParentTransform(gameObject.transform);
+
+            // Otherwise, check to see if there is any NetworkObject from the root GameObject down to all children.
+            // If not, notify the user that NetworkBehaviours require that the relative GameObject has a NetworkObject component.
+            var networkObject = rootTransform.GetComponent<NetworkObject>();
             if (networkObject == null)
             {
-                networkObject = gameObject.GetComponentInChildren<NetworkObject>();
+                networkObject = rootTransform.GetComponentInChildren<NetworkObject>();
 
                 if (networkObject == null)
                 {