Switched NetworkConfig GetConfig to BitWriter

Author: TwoTenPvP

MLAPI/Data/NetworkConfig.cs

@@ -1,4 +1,5 @@
 using MLAPI.MonoBehaviours.Core;
+using MLAPI.NetworkingManagerComponents.Binary;
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -155,53 +156,51 @@ public byte[] GetConfig(bool cache = true)
             if (ConfigHash != null && cache)
                 return ConfigHash;
 
-            using (MemoryStream writeStream = new MemoryStream())
+            using (BitWriter writer = new BitWriter())
             {
-                using (BinaryWriter writer = new BinaryWriter(writeStream))
+                writer.WriteUShort(ProtocolVersion);
+                for (int i = 0; i < Channels.Count; i++)
                 {
-                    writer.Write(ProtocolVersion);
-                    for (int i = 0; i < Channels.Count; i++)
-                    {
-                        writer.Write(Channels[i].Name);
-                        writer.Write((byte)Channels[i].Type);
-                        if (EnableEncryption)
-                            writer.Write(Channels[i].Encrypted);
-                    }
-                    for (int i = 0; i < MessageTypes.Count; i++)
-                    {
-                        writer.Write(MessageTypes[i].Name);
-                        if (AllowPassthroughMessages)
-                            writer.Write(MessageTypes[i].Passthrough);
-                    }
-                    if (EnableSceneSwitching)
+                    writer.WriteString(Channels[i].Name);
+                    writer.WriteByte((byte)Channels[i].Type);
+                    if (EnableEncryption)
+                        writer.WriteBool(Channels[i].Encrypted);
+                }
+                for (int i = 0; i < MessageTypes.Count; i++)
+                {
+                    writer.WriteString(MessageTypes[i].Name);
+                    if (AllowPassthroughMessages)
+                        writer.WriteBool(MessageTypes[i].Passthrough);
+                }
+                if (EnableSceneSwitching)
+                {
+                    for (int i = 0; i < RegisteredScenes.Count; i++)
                     {
-                        for (int i = 0; i < RegisteredScenes.Count; i++)
-                        {
-                            writer.Write(RegisteredScenes[i]);
-                        }
+                        writer.WriteString(RegisteredScenes[i]);
                     }
-                    if(HandleObjectSpawning)
+                }
+                if (HandleObjectSpawning)
+                {
+                    for (int i = 0; i < NetworkedPrefabs.Count; i++)
                     {
-                        for (int i = 0; i < NetworkedPrefabs.Count; i++)
-                        {
-                            writer.Write(NetworkedPrefabs[i].name);
-                        }
+                        writer.WriteString(NetworkedPrefabs[i].name);
                     }
-                    writer.Write(HandleObjectSpawning);
-                    writer.Write(EnableEncryption);
-                    writer.Write(AllowPassthroughMessages);
-                    writer.Write(EnableSceneSwitching);
-                    writer.Write(SignKeyExchange);
                 }
+                writer.WriteBool(HandleObjectSpawning);
+                writer.WriteBool(EnableEncryption);
+                writer.WriteBool(AllowPassthroughMessages);
+                writer.WriteBool(EnableSceneSwitching);
+                writer.WriteBool(SignKeyExchange);
+
                 using (SHA256Managed sha256 = new SHA256Managed())
                 {
                     //Returns a 256 bit / 32 byte long checksum of the config
                     if (cache)
                     {
-                        ConfigHash = sha256.ComputeHash(writeStream.ToArray());
+                        ConfigHash = sha256.ComputeHash(writer.Finalize());
                         return ConfigHash;
                     }
-                    return sha256.ComputeHash(writeStream.ToArray());
+                    return sha256.ComputeHash(writer.Finalize());
                 }
             }
         }