fix: Compile error when a class with Rpcs inherits from an intermediate base class with no Rpcs. (#2751)

* Fix: Compile error when a class with Rpcs inherits from an intermediate base class with no Rpcs.

* Changelog

* Same thing, but actually doing it correctly this time.

* Avoiding unnecessary formatting changes.

Author: ShadauxCat

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com).
 
+## [Unreleased]
+
+### Fixed
+
+- Fixed a bug where having a class with Rpcs that inherits from a class without Rpcs that inherits from NetworkVariable would cause a compile error. (#2751)
+
 ## [1.7.0] - 2023-10-11
 
 ### Added

com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs

@@ -1237,8 +1237,10 @@ private void ProcessNetworkBehaviour(TypeDefinition typeDefinition, string[] ass
                 }
             }
 
-            if (rpcHandlers.Count > 0)
+            //if (rpcHandlers.Count > 0)
             {
+
+                // This always needs to generate even if it's empty.
                 var initializeRpcsMethodDef = new MethodDefinition(
                         k_NetworkBehaviour___initializeRpcs,
                         MethodAttributes.Family | MethodAttributes.Virtual | MethodAttributes.HideBySig,

com.unity.netcode.gameobjects/Tests/Runtime/RpcTests.cs

@@ -12,6 +12,20 @@ namespace Unity.Netcode.RuntimeTests
 {
     public class RpcTests : NetcodeIntegrationTest
     {
+        public class CompileTimeNoRpcsBaseClassTest : NetworkBehaviour
+        {
+
+        }
+
+        public class CompileTimeHasRpcsChildClassDerivedFromNoRpcsBaseClassTest : CompileTimeNoRpcsBaseClassTest
+        {
+            [ServerRpc]
+            public void SomeDummyServerRpc()
+            {
+
+            }
+        }
+
         public class GenericRpcTestNB<T> : NetworkBehaviour where T : unmanaged
         {
             public event Action<T, ServerRpcParams> OnServer_Rpc;