Skip to content

Migrate Mono APIs to CoreCLR-compatible APIs for com.unity.postprocessing #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MiroBrodlovaUnityGit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate Mono APIs to CoreCLR-compatible APIs for com.unity.postprocessing #8236

MiroBrodlovaUnityGit wants to merge 1 commit into from
+8 −0

Conversation

@MiroBrodlovaUnityGit
Copy link
Contributor

@MiroBrodlovaUnityGit MiroBrodlovaUnityGit commented Nov 25, 2025 •
edited
Loading

Purpose of PR

This PR replaces all instances of analyzer-highlighted Mono API calls with CoreCLR-compatible API calls for the package com.unity.postprocessing, and is part of Epic SCP-1555.

Further Context

JIRA-ticket

Testing

Running the default job-suite. Please share if there are additional steps needed!

@MiroBrodlovaUnityGit
Migrate AppDomain.GetAssemblies() in PostProcessing RuntimeUtilities
cc97131 
- RuntimeUtilities.cs: Add conditional compilation (line 1214)
- Added using UnityEngine.Assemblies with conditional directive
- Maintains backward compatibility with older Unity versions
@MiroBrodlovaUnityGit MiroBrodlovaUnityGit marked this pull request as ready for review November 28, 2025 08:02
BenGraterUnity
BenGraterUnity requested changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@BenGraterUnity BenGraterUnity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may be some confusion. Only files for the com.unity.postprocessing package should be included here. Any files for other packages should be done on the main repo.

Please remove the files which are not part of the com.unity.postprocessing package.

@MiroBrodlovaUnityGit
Copy link
Contributor Author

MiroBrodlovaUnityGit commented Nov 28, 2025

I think there may be some confusion. Only files for the com.unity.postprocessing package should be included here. Any files for other packages should be done on the main repo.

Please remove the files which are not part of the com.unity.postprocessing package.

Thanks for the clarification Ben! Will do so :)

@MiroBrodlovaUnityGit
Copy link
Contributor Author

MiroBrodlovaUnityGit commented Nov 28, 2025

There we go! Only changes to com.unity.postprocessing should now be included! 🙂

@MiroBrodlovaUnityGit MiroBrodlovaUnityGit changed the title Migrate Mono APIs to CoreCLR-compatible APIs Migrate Mono APIs to CoreCLR-compatible APIs for com.unity.postprocessing Nov 28, 2025
BenGraterUnity
BenGraterUnity approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@BenGraterUnity BenGraterUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in 6000.5.0a3 Windows/DX12. 👍

@MiroBrodlovaUnityGit
Copy link
Contributor Author

MiroBrodlovaUnityGit commented Dec 4, 2025

Thanks for the help Ben!

Just wanted to double check, is there something I should do/any jobs I should run to get this PR in a land:able state? Or is it mostly now to sit tight and wait a bit? :) Asking to make sure I do everything I should do!

@BenGraterUnity
Copy link
Contributor

BenGraterUnity commented Dec 5, 2025 •
edited
Loading

@MiroBrodlovaUnityGit Please merge master and add your CHANGELOG notes to the [Unreleased] section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenGraterUnity BenGraterUnity BenGraterUnity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MiroBrodlovaUnityGit @BenGraterUnity