provide better handling of network error/user inputs (#469)

* Postpone request building until execution to catch errors

* add titles to notifications, change texts

* change text

* throw on buildDirPath and testsDirPath failure

* fix heatbeat error log message

* validate tests, build, remote paths in wizard and settings

* add notifyNotConnected

* uncomment detect

* fix messages keys

* fixes after rebase

* remove unused code & fix some styles issues

* fix targetPath conversion to remote version

* fix remote mapping

* add some tests for building grpc requests

* fix tests

* Fix notifications messages, fix log level, relative paths

- Relative paths entered by user are striped of leading slashed /\
- fixed log depth - wrong stacktrace was taken
- changed notification messages' texts

* Remove empty companion

* remove unused deps

* change texts

* renames, small refactorings

* stop indicator only if started

* Start indicator even if no statusbar

- now progress indicator is started even if there is no statusBar to
  display progress
- fixed condition in TestsStreamHandler for showing notification

* fix typos

* undo vscode config change

Author: vol0n

clion-plugin/build.gradle.kts

@@ -35,7 +35,7 @@ plugins {
     // Java support
     id("java")
     // Kotlin support
-    id("org.jetbrains.kotlin.jvm") version "1.6.10"
+    id("org.jetbrains.kotlin.jvm") version "1.7.20"
     // Gradle IntelliJ Plugin
     id("org.jetbrains.intellij") version "1.5.2"
     // Gradle Changelog Plugin
@@ -91,11 +91,11 @@ detekt {
     allRules = false // activate all available (even unstable) rules.
 }
 
-//kotlin {
-//    jvmToolchain {
-//        (this as JavaToolchainSpec).languageVersion.set(JavaLanguageVersion.of(11))
-//    }
-//}
+kotlin {
+    jvmToolchain {
+        (this as JavaToolchainSpec).languageVersion.set(JavaLanguageVersion.of(11))
+    }
+}
 
 protobuf {
     protoc {
@@ -194,7 +194,7 @@ tasks {
         setScanForTestClasses(false)
         // Only run tests from classes that end with "Test"
         include("**/*Test.class")
-        exclude("**/*BaseGenerationTestCaseTest.class")
+        exclude("**/*BaseGenerationTestCaseTest.class", "**/*BaseBuildingTest.class")
         systemProperty("idea.log.debug.categories", true)
         systemProperty("idea.log.trace.categories", true)
 

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/UTBotStartupActivity.kt

@@ -4,6 +4,7 @@ import com.intellij.ide.util.RunOnceUtil
 import com.intellij.openapi.components.service
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.StartupActivity
+import org.tinylog.kotlin.Logger
 import org.utbot.cpp.clion.plugin.client.ManagedClient
 import org.utbot.cpp.clion.plugin.settings.settings
 
@@ -12,6 +13,7 @@ class UTBotStartupActivity : StartupActivity {
         // We initialize Client here, so that initialization will not happen
         // when user issues first generation request which would cause a UI freeze.
         if (project.settings.storedSettings.isPluginEnabled) {
+            Logger.info("startup activity is run: Initializing client")
             initializeClient(project)
             guessPathsOnFirstOpen(project)
         }

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/AskServerToGenerateBuildDir.kt

@@ -3,10 +3,18 @@ package org.utbot.cpp.clion.plugin.actions
 import com.intellij.openapi.actionSystem.AnActionEvent
 import org.utbot.cpp.clion.plugin.UTBot
 import org.utbot.cpp.clion.plugin.client.requests.CreateBuildDirRequest
+import org.utbot.cpp.clion.plugin.grpc.GrpcRequestBuilderFactory
+import org.utbot.cpp.clion.plugin.utils.activeProject
+import org.utbot.cpp.clion.plugin.utils.client
+import testsgen.Testgen
 
 class AskServerToGenerateBuildDir : UTBotBaseAction(UTBot.message("projectConfigure.generate.buildDir")) {
 
-    override fun actionPerformed(e: AnActionEvent) = CreateBuildDirRequest(e).execute()
+    override fun actionPerformed(e: AnActionEvent) = CreateBuildDirRequest(
+        GrpcRequestBuilderFactory(e.activeProject()).createProjectConfigRequestBuilder(Testgen.ConfigMode.CREATE_BUILD_DIR),
+        e.activeProject(),
+        e.activeProject().client
+    ).execute()
 
     override fun updateIfEnabled(e: AnActionEvent) {
         e.presentation.isEnabledAndVisible = e.project != null

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/RefreshTargetsAction.kt

@@ -1,7 +1,6 @@
 package org.utbot.cpp.clion.plugin.actions
 
 import com.intellij.icons.AllIcons
-import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.components.service
 import org.utbot.cpp.clion.plugin.ui.utbotToolWindow.targetToolWindow.UTBotTargetsController
@@ -16,4 +15,4 @@ class RefreshTargetsAction: UTBotBaseAction() {
         e.presentation.isEnabledAndVisible = e.project != null
         e.presentation.icon = AllIcons.Actions.Refresh
     }
-}
+}

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/ShowSettings.kt

@@ -0,0 +1,13 @@
+package org.utbot.cpp.clion.plugin.actions
+
+import com.intellij.openapi.actionSystem.AnActionEvent
+import com.intellij.openapi.options.ShowSettingsUtil
+import com.intellij.openapi.project.DumbAwareAction
+import org.utbot.cpp.clion.plugin.UTBot
+import org.utbot.cpp.clion.plugin.settings.UTBotConfigurable
+
+class ShowSettingsAction : DumbAwareAction(UTBot.message("show.settings.text"))/*, LightEditCompatible*/ {
+    override fun actionPerformed(e: AnActionEvent) {
+        ShowSettingsUtil.getInstance().showSettingsDialog(e.project, UTBotConfigurable::class.java)
+    }
+}

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/UTBotBaseToggleAction.kt

@@ -20,4 +20,4 @@ abstract class UTBotBaseToggleAction(
     }
 
     abstract fun updateIfEnabled(e: AnActionEvent)
-}
+}

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/configure/ConfigureProjectAction.kt

@@ -4,11 +4,16 @@ import com.intellij.openapi.actionSystem.AnActionEvent
 import org.utbot.cpp.clion.plugin.UTBot
 import org.utbot.cpp.clion.plugin.actions.UTBotBaseAction
 import org.utbot.cpp.clion.plugin.client.requests.CheckProjectConfigurationRequest
+import org.utbot.cpp.clion.plugin.grpc.GrpcRequestBuilderFactory
 import org.utbot.cpp.clion.plugin.utils.activeProject
+import testsgen.Testgen
 
 class ConfigureProjectAction : UTBotBaseAction(UTBot.message("projectConfigure.configure")) {
 
-    override fun actionPerformed(e: AnActionEvent) = CheckProjectConfigurationRequest(e.activeProject()).execute()
+    override fun actionPerformed(e: AnActionEvent) = CheckProjectConfigurationRequest(
+        GrpcRequestBuilderFactory(e.activeProject()).createProjectConfigRequestBuilder(Testgen.ConfigMode.CHECK),
+        e.activeProject()
+    ).execute()
 
     override fun updateIfEnabled(e: AnActionEvent) {
         e.presentation.isEnabledAndVisible = e.project != null

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/configure/ReconfigureProjectAction.kt

@@ -2,9 +2,9 @@ package org.utbot.cpp.clion.plugin.actions.configure
 
 import com.intellij.openapi.actionSystem.AnActionEvent
 import org.utbot.cpp.clion.plugin.UTBot
-import org.utbot.cpp.clion.plugin.actions.UTBotBaseAction
-import org.utbot.cpp.clion.plugin.grpc.getProjectConfigGrpcRequest
 import org.utbot.cpp.clion.plugin.client.requests.CheckProjectConfigurationRequest
+import org.utbot.cpp.clion.plugin.actions.UTBotBaseAction
+import org.utbot.cpp.clion.plugin.grpc.GrpcRequestBuilderFactory
 import org.utbot.cpp.clion.plugin.utils.activeProject
 import testsgen.Testgen
 
@@ -13,7 +13,7 @@ class ReconfigureProjectAction: UTBotBaseAction(UTBot.message("projectConfigure.
     override fun actionPerformed(e: AnActionEvent) {
         val project = e.activeProject()
         CheckProjectConfigurationRequest(
-            getProjectConfigGrpcRequest(project, Testgen.ConfigMode.ALL),
+            GrpcRequestBuilderFactory(project).createProjectConfigRequestBuilder(Testgen.ConfigMode.ALL),
             project,
         ).execute()
     }

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/generate/BaseGenerateTestsAction.kt

@@ -2,6 +2,8 @@ package org.utbot.cpp.clion.plugin.actions.generate
 
 import com.intellij.openapi.actionSystem.AnActionEvent
 import org.utbot.cpp.clion.plugin.actions.UTBotBaseAction
+import org.utbot.cpp.clion.plugin.client.ManagedClient
+import org.utbot.cpp.clion.plugin.utils.activeProject
 import org.utbot.cpp.clion.plugin.utils.client
 
 abstract class BaseGenerateTestsAction : UTBotBaseAction() {
@@ -10,7 +12,7 @@ abstract class BaseGenerateTestsAction : UTBotBaseAction() {
         val isDefined: Boolean = isDefined(e)
 
         e.presentation.isVisible = isDefined
-        e.presentation.isEnabled = isDefined && e.client.isServerAvailable()
+        e.presentation.isEnabled = isDefined && ManagedClient.isConnectedToServer(e.activeProject())
     }
 
     /**

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/actions/generate/GenerateForAssertionAction.kt

@@ -3,13 +3,15 @@ package org.utbot.cpp.clion.plugin.actions.generate
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
 import org.utbot.cpp.clion.plugin.client.requests.test.AssertionRequest
-import org.utbot.cpp.clion.plugin.grpc.getAssertionGrpcRequest
+import org.utbot.cpp.clion.plugin.grpc.GrpcRequestBuilderFactory
 import org.utbot.cpp.clion.plugin.utils.activeProject
+import org.utbot.cpp.clion.plugin.utils.getFilePathUnsafe
+import org.utbot.cpp.clion.plugin.utils.getLineNumberUnsafe
 
 class GenerateForAssertionAction : BaseGenerateTestsAction() {
     override fun actionPerformed(e: AnActionEvent) =
         AssertionRequest(
-            getAssertionGrpcRequest(e),
+            GrpcRequestBuilderFactory(e.activeProject()).createAssertionRequestBuilder(e.getLineNumberUnsafe(), e.getFilePathUnsafe()),
             e.activeProject(),
         ).execute()