refactor: simplify install.sh

Author: Chemaclass

install.sh

@@ -6,16 +6,6 @@ function is_git_installed() {
   command -v git > /dev/null 2>&1
 }
 
-function get_latest_tag() {
-  local repository_url=$1
-
-  git ls-remote --tags "$repository_url" |
-    awk '{print $2}' |
-    sed 's|^refs/tags/||' |
-    sort -Vr |
-    head -n 1
-}
-
 function build_and_install_beta() {
   echo "> Downloading non-stable version: 'beta'"
 
@@ -92,11 +82,7 @@ elif [[ $# -eq 2 ]]; then
 fi
 
 BASHUNIT_GIT_REPO="https://github.com/TypedDevs/bashunit"
-if is_git_installed; then
-    LATEST_BASHUNIT_VERSION="$(get_latest_tag "$BASHUNIT_GIT_REPO")"
-else
-    LATEST_BASHUNIT_VERSION="0.22.2"
-fi
+LATEST_BASHUNIT_VERSION="0.22.2"
 TAG="$LATEST_BASHUNIT_VERSION"
 
 cd "$(dirname "$0")"

src/env.sh

@@ -87,13 +87,17 @@ function env::is_no_output_enabled() {
 }
 
 function env::active_internet_connection() {
+  if [[ "${BASHUNIT_NO_NETWORK:-}" == "true" ]]; then
+    return 1
+  fi
+
   if command -v curl >/dev/null 2>&1; then
     curl -sfI https://github.com >/dev/null 2>&1 && return 0
   elif command -v wget >/dev/null 2>&1; then
     wget -q --spider https://github.com && return 0
   fi
 
-  if ping -c 1 -W 3 github.com &> /dev/null; then
+  if ping -c 1 -W 3 google.com &> /dev/null; then
     return 0
   fi
 

tests/acceptance/bashunit_upgrade_test.sh

@@ -28,7 +28,11 @@ function tear_down_after_script() {
 
 function set_up() {
   ./build.sh "$TMP_DIR" >/dev/null
-  LATEST_VERSION="$(helpers::get_latest_tag)"
+  if [[ "$ACTIVE_INTERNET" == true ]] && [[ "$HAS_GIT" == true ]]; then
+    LATEST_VERSION="$(helpers::get_latest_tag)"
+  else
+    LATEST_VERSION="${BASHUNIT_VERSION}"
+  fi
   TEST_ENV_FILE="tests/acceptance/fixtures/.env.default"
 }