fix: Suggestion menu positioning #2232
Open
+26
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
reviewed
Dec 5, 2025
| Object.assign(elements.floating.style, { | ||
| maxHeight: `${availableHeight - 10}px`, | ||
| }); | ||
| apply(p) { |
Collaborator
There was a problem hiding this comment.
I'm not sure about this, maybe @nperez0111 can double check when he's back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where if the suggestion menu was displayed above the trigger character (when there was not enough space to display it below), and only showed a few items, there would be a large gap between the menu and trigger character. This was because the suggestion menu had a hard-coded minimum height, which wasn't filled when displaying a small number of items.
Also, the positioning has generally been improved to better take advantage of the available screen space.
Rationale
This issue has made the suggestion menu feel janky in some situations.
Changes
SuggestionMenuControllerFloating UI optionssizemiddleware.flipmiddleware withautoPlacement. The difference is thatautoPlacementalways displays the menu on the side that has more space, whereasfliponly changes the side when there is not enough available space for the menu.Impact
N/A
Testing
Updated Notion UI testing doc.
Screenshots/Video
N/A
Checklist
Additional Notes