Skip to content

Commit 4273f8c

Browse files
committed
Modify the format of the air waybill number
Fix Exception Handling
1 parent 4fddf0c commit 4273f8c

File tree

7 files changed

+41
-3
lines changed

7 files changed

+41
-3
lines changed

README.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ begin
3838
puts response
3939
rescue TrackingMore::TrackingMoreException => e
4040
puts "Caught Custom Exception: #{e.message}"
41+
rescue StandardError => e
42+
puts "Caught Standard Error: #{e.message}"
4143
end
4244

4345
```
@@ -94,6 +96,8 @@ begin
9496
puts response
9597
rescue TrackingMore::TrackingMoreException => e
9698
puts "Caught Custom Exception: #{e.message}"
99+
rescue StandardError => e
100+
puts "Caught Standard Error: #{e.message}"
97101
end
98102
```
99103

@@ -106,6 +110,8 @@ begin
106110
puts response
107111
rescue TrackingMore::TrackingMoreException => e
108112
puts "Caught Custom Exception: #{e.message}"
113+
rescue StandardError => e
114+
puts "Caught Standard Error: #{e.message}"
109115
end
110116
```
111117

@@ -119,6 +125,8 @@ begin
119125
puts response
120126
rescue TrackingMore::TrackingMoreException => e
121127
puts "Caught Custom Exception: #{e.message}"
128+
rescue StandardError => e
129+
puts "Caught Standard Error: #{e.message}"
122130
end
123131
```
124132

@@ -134,6 +142,8 @@ begin
134142
puts response
135143
rescue TrackingMore::TrackingMoreException => e
136144
puts "Caught Custom Exception: #{e.message}"
145+
rescue StandardError => e
146+
puts "Caught Standard Error: #{e.message}"
137147
end
138148
```
139149

@@ -146,6 +156,8 @@ begin
146156
puts response
147157
rescue TrackingMore::TrackingMoreException => e
148158
puts "Caught Custom Exception: #{e.message}"
159+
rescue StandardError => e
160+
puts "Caught Standard Error: #{e.message}"
149161
end
150162
```
151163

@@ -159,6 +171,8 @@ begin
159171
puts response
160172
rescue TrackingMore::TrackingMoreException => e
161173
puts "Caught Custom Exception: #{e.message}"
174+
rescue StandardError => e
175+
puts "Caught Standard Error: #{e.message}"
162176
end
163177
```
164178

@@ -171,6 +185,8 @@ begin
171185
puts response
172186
rescue TrackingMore::TrackingMoreException => e
173187
puts "Caught Custom Exception: #{e.message}"
188+
rescue StandardError => e
189+
puts "Caught Standard Error: #{e.message}"
174190
end
175191
```
176192

@@ -183,6 +199,8 @@ begin
183199
puts response
184200
rescue TrackingMore::TrackingMoreException => e
185201
puts "Caught Custom Exception: #{e.message}"
202+
rescue StandardError => e
203+
puts "Caught Standard Error: #{e.message}"
186204
end
187205
```
188206
## Air Waybill
@@ -195,6 +213,8 @@ begin
195213
puts response
196214
rescue TrackingMore::TrackingMoreException => e
197215
puts "Caught Custom Exception: #{e.message}"
216+
rescue StandardError => e
217+
puts "Caught Standard Error: #{e.message}"
198218
end
199219
```
200220

examples/air_waybill_example.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,6 @@
99
puts response
1010
rescue TrackingMore::TrackingMoreException => e
1111
puts "Caught Custom Exception: #{e.message}"
12-
end
12+
rescue StandardError => e
13+
puts "Caught Standard Error: #{e.message}"
14+
end

examples/courier_example.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
puts response
99
rescue TrackingMore::TrackingMoreException => e
1010
puts "Caught Custom Exception: #{e.message}"
11+
rescue StandardError => e
12+
puts "Caught Standard Error: #{e.message}"
1113
end
1214

1315

@@ -17,4 +19,6 @@
1719
puts response
1820
rescue TrackingMore::TrackingMoreException => e
1921
puts "Caught Custom Exception: #{e.message}"
22+
rescue StandardError => e
23+
puts "Caught Standard Error: #{e.message}"
2024
end

examples/tracking_example.rb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
puts response
1010
rescue TrackingMore::TrackingMoreException => e
1111
puts "Caught Custom Exception: #{e.message}"
12+
rescue StandardError => e
13+
puts "Caught Standard Error: #{e.message}"
1214
end
1315

1416
begin
@@ -19,6 +21,8 @@
1921
puts response
2022
rescue TrackingMore::TrackingMoreException => e
2123
puts "Caught Custom Exception: #{e.message}"
24+
rescue StandardError => e
25+
puts "Caught Standard Error: #{e.message}"
2226
end
2327

2428
begin
@@ -27,6 +31,8 @@
2731
puts response
2832
rescue TrackingMore::TrackingMoreException => e
2933
puts "Caught Custom Exception: #{e.message}"
34+
rescue StandardError => e
35+
puts "Caught Standard Error: #{e.message}"
3036
end
3137

3238
begin
@@ -36,6 +42,8 @@
3642
puts response
3743
rescue TrackingMore::TrackingMoreException => e
3844
puts "Caught Custom Exception: #{e.message}"
45+
rescue StandardError => e
46+
puts "Caught Standard Error: #{e.message}"
3947
end
4048

4149
begin
@@ -44,6 +52,8 @@
4452
puts response
4553
rescue TrackingMore::TrackingMoreException => e
4654
puts "Caught Custom Exception: #{e.message}"
55+
rescue StandardError => e
56+
puts "Caught Standard Error: #{e.message}"
4757
end
4858

4959
begin
@@ -52,4 +62,6 @@
5262
puts response
5363
rescue TrackingMore::TrackingMoreException => e
5464
puts "Caught Custom Exception: #{e.message}"
65+
rescue StandardError => e
66+
puts "Caught Standard Error: #{e.message}"
5567
end

lib/trackingmore/air_waybill.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ def self.create_an_air_waybill(params = {})
66
if params["awb_number"].to_s.empty?
77
raise TrackingMore::TrackingMoreException.new(TrackingMore::Consts::ErrMissingAwbNumber)
88
end
9-
if params["awb_number"].length != 12
9+
if !params['awb_number'].match(/^\d{3}[ -]?(\d{8})$/)
1010
raise TrackingMore::TrackingMoreException.new(TrackingMore::Consts::ErrInvalidAirWaybillFormat)
1111
end
1212
TrackingMore::Request.make_request('post',"awb",params)

lib/trackingmore/const.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ class Consts
77
ErrMissingAwbNumber = 'Awb number cannot be empty';
88
ErrMaxTrackingNumbersExceeded = 'Max. 40 tracking numbers create in one call';
99
ErrEmptyId = 'Id cannot be empty';
10-
ErrInvalidAirWaybillFormat = 'The air waybill number format is invalid and can only be 12 digits in length';
10+
ErrInvalidAirWaybillFormat = 'The air waybill number format is invalid';
1111
end
1212
end

trackingmore-0.1.0.gem

-8 KB
Binary file not shown.

0 commit comments

Comments
 (0)