From 4fa3c849c9d572234d7940e14e4c99cb787d6559 Mon Sep 17 00:00:00 2001 From: nullishamy Date: Sun, 3 Aug 2025 17:55:50 +0100 Subject: [PATCH 1/2] feat: check for established member role --- src/api/checks.ts | 10 ++++++++++ src/config.ts | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/api/checks.ts b/src/api/checks.ts index bfc71d5..09947c2 100644 --- a/src/api/checks.ts +++ b/src/api/checks.ts @@ -94,6 +94,16 @@ export async function runNonCriticalChecks ( result = false } + if (submission.author.roles.cache.has(config.roles().establishedMember)) { + genericLog.warning({ + type: 'text', + content: 'Submitter does not appear to have Established Member role. Check and reject as neccesary.', + ctx: submission.reviewThread + }) + + result = false + } + if (isGitHubSource(submission)) { const licenseRes = await runGitHubChecks(submission) diff --git a/src/config.ts b/src/config.ts index 6d9716a..077321c 100644 --- a/src/config.ts +++ b/src/config.ts @@ -108,7 +108,7 @@ const rejectionValues: RejectionTemplate[] = [ key: 'role-requirement', enumValue: { name: 'Role requirement', value: 'role-requirement' }, prettyValue: 'Required role is missing', - execute: ({ user }: RejectionParams) => `${user}, your project has been rejected because you lack the VC Access role.`, + execute: ({ user }: RejectionParams) => `${user}, your project has been rejected because you lack the Established Member role. You are welcome to resubmit the project once you have the role.`, location: () => 'thread' } ] @@ -160,6 +160,7 @@ const config = { */ roles: () => ({ veterans: env.role('VETERANS_ROLE_ID', env.guild(process.env.NODE_ENV === 'production' ? 'MAIN_GUILD_ID' : 'DEVELOPMENT_GUILD_ID')), + establishedMember: '889228904622075925', staff: env.role('STAFF_ROLE_ID', env.guild(process.env.NODE_ENV === 'production' ? 'MAIN_GUILD_ID' : 'DEVELOPMENT_GUILD_ID')) }), /** From ab05cfd9aaf410cde34ab826802bcc50b978f3c1 Mon Sep 17 00:00:00 2001 From: nullishamy Date: Sun, 3 Aug 2025 17:59:08 +0100 Subject: [PATCH 2/2] fix: actually check if they have it lmao --- src/api/checks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/api/checks.ts b/src/api/checks.ts index 09947c2..81cf4b8 100644 --- a/src/api/checks.ts +++ b/src/api/checks.ts @@ -94,7 +94,7 @@ export async function runNonCriticalChecks ( result = false } - if (submission.author.roles.cache.has(config.roles().establishedMember)) { + if (!submission.author.roles.cache.has(config.roles().establishedMember)) { genericLog.warning({ type: 'text', content: 'Submitter does not appear to have Established Member role. Check and reject as neccesary.',