Add Shor's Algorithm implementation #13989
Conversation
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from fractions import Fraction | ||
|
|
||
|
|
||
| def gcd(a: int, b: int) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
| return a | ||
|
|
||
|
|
||
| def is_prime(n: int) -> bool: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| return all(n % i != 0 for i in range(3, int(math.sqrt(n)) + 1, 2)) | ||
|
|
||
|
|
||
| def is_perfect_power(n: int) -> tuple[int, int] | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| return result | ||
|
|
||
|
|
||
| def find_order(a: int, n: int) -> int | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: n
| return None | ||
|
|
||
|
|
||
| def quantum_period_finding_simulation(a: int, n: int) -> int | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: n
| return convergents | ||
|
|
||
|
|
||
| def shors_algorithm(n: int, max_attempts: int = 10) -> tuple[int, int] | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| return None | ||
|
|
||
|
|
||
| def demonstrate_rsa_vulnerability(p: int, q: int) -> dict: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: p
Please provide descriptive name for the parameter: q
| return result | ||
|
|
||
|
|
||
| def factor_with_explanation(n: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
algorithms-keeper
bot
added
awaiting reviews
1 participant
Describe your change:
Checklist:
Fixes #12318
This PR implements Shor's Algorithm for integer factorization as a classical
simulation, demonstrating how the algorithm breaks RSA cryptography without
requiring Qiskit or Cirq.