-
Notifications
You must be signed in to change notification settings - Fork 183
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug 📝
In the highlightById method of the Highlighter component, if a modelIdMap is passed in the exclude parameter, the method performs an intersection, producing a map that intersects the IDs to highlight with the IDs to exclude. However, shouldn’t the items to be excluded be removed using the remove method instead?
In fact, when using it now the method highlight only the items that are in the map passed through the exclude attribute.
I'm pointing to this line:
| map = OBC.ModelIdMapUtils.intersect([map, exclude]); |
Reproduction ▶️
No response
Steps to reproduce 🔢
Simply use the method highlighter.highlightById somewhere, using the exclude attribute of it.
System Info 💻
System:
OS: Windows 11 10.0.22621
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 1.68 GB / 15.89 GB
Binaries:
Node: 22.17.1 - C:\Program Files\nodejs\node.EXE
npm: 11.5.2 - C:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: 143.0.7499.40
Edge: Chromium (140.0.3485.54)
Internet Explorer: 11.0.22621.3527Used Package Manager 📦
npm
Error Trace/Logs 📃
No response
Validations ✅
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
- Check that this is a concrete bug. For Q&A join our Community.
- The provided reproduction is a minimal reproducible example of the bug.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working