update get header with len inputs mandatory

Author: cdgwoon

build_test_resources/linkfuntest.c

@@ -63,7 +63,7 @@ void my_app_simple_get_calloc_from_pool(ngx_link_func_ctx_t *ctx) {
 }
 
 void my_app_simple_get_header_param(ngx_link_func_ctx_t *ctx) {
-    u_char *req_content_type = ngx_link_func_get_header(ctx, "Host");
+    u_char *req_content_type = ngx_link_func_get_header(ctx, "Host", sizeof("Host") - 1);
 
     if (req_content_type) {
         ngx_link_func_log_info(ctx, req_content_type);
@@ -86,8 +86,8 @@ char* login(const char* userId, const char*pass) {
 void my_simple_authentication(ngx_link_func_ctx_t *ctx) {
 
     ngx_link_func_log_info(ctx, "Authenticating");
-    char *userId = (char*) ngx_link_func_get_header(ctx, "userId");
-    char *userPass = (char*) ngx_link_func_get_header(ctx, "userPass");
+    char *userId = (char*) ngx_link_func_get_header(ctx, "userId", sizeof("userId") - 1);
+    char *userPass = (char*) ngx_link_func_get_header(ctx, "userPass", sizeof("userPass") - 1);
     char* userName;
 
     if ( userId == NULL || strlen(userId) == 0) {

config

@@ -24,7 +24,7 @@ ngx_feature_incs="#include <ngx_link_func_module.h>"
 ngx_feature_path=
 ngx_feature_libs=
 # ngx_feature_exit_if_not_found=yes
-ngx_feature_test="int ngx_link_func_module_current_version_=ngx_link_func_module_version_30;"
+ngx_feature_test="int ngx_link_func_module_current_version_=ngx_link_func_module_version_31;"
 . auto/feature
 
 if [ $ngx_found != yes ]; then

src/ngx_link_func_module.c

@@ -206,7 +206,7 @@ void ngx_link_func_log_info(ngx_link_func_ctx_t *ctx, const char* msg);
 void ngx_link_func_log_warn(ngx_link_func_ctx_t *ctx, const char* msg);
 void ngx_link_func_log_err(ngx_link_func_ctx_t *ctx, const char* msg);
 char *ngx_link_func_strdup(ngx_link_func_ctx_t *ctx, const char *src);
-u_char* ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key);
+u_char* ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key, size_t keylen);
 int ngx_link_func_add_header_in(ngx_link_func_ctx_t *ctx, const char *key, size_t keylen, const char *value, size_t val_len );
 int ngx_link_func_add_header_out(ngx_link_func_ctx_t *ctx, const char *key, size_t keylen, const char *value, size_t val_len );
 void* ngx_link_func_get_query_param(ngx_link_func_ctx_t *ctx, const char *key);
@@ -711,7 +711,7 @@ ngx_http_link_func_pre_configuration(ngx_conf_t *cf) {
     return NGX_ERROR;
 #endif
 
-#ifndef ngx_link_func_module_version_30
+#ifndef ngx_link_func_module_version_31
     ngx_conf_log_error(NGX_LOG_EMERG, cf,  0, "%s", "the ngx_http_link_func_module.h might not be latest or not found in the c header path, \
         please copy latest ngx_http_link_func_module.h to your /usr/include or /usr/local/include or relavent header search path \
         with read and write permission.");
@@ -1670,11 +1670,12 @@ ngx_http_link_func_strdup_with_p(ngx_pool_t *pool, const char *src, size_t len)
 }
 
 u_char*
-ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key) {
+ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key, size_t keylen) {
     ngx_http_request_t *r = (ngx_http_request_t*)ctx->__r__;
     ngx_list_part_t *part = &r->headers_in.headers.part;
     ngx_table_elt_t *header = part->elts;
     unsigned int i;
+    size_t header_len;
     for (i = 0; /* void */; i++) {
         if (i >= part->nelts) {
             if (part->next == NULL) {
@@ -1686,7 +1687,8 @@ ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key) {
             i = 0;
         }
 
-        if (ngx_strncasecmp( (u_char*) key, header[i].key.data , header[i].key.len) == 0 ) {
+        header_len = header[i].key.len;
+        if ( header_len == keylen && ngx_strncasecmp( (u_char*) key, header[i].key.data , header_len) == 0 ) {
             u_char *ret = ngx_pcalloc(r->pool, header[i].value.len + 1);
             ngx_memcpy(ret, header[i].value.data, header[i].value.len);
             return ret;

src/ngx_link_func_module.h

@@ -40,7 +40,7 @@
 #include <stdlib.h>
 #include <stdint.h>
 
-#define ngx_link_func_module_version_30 30
+#define ngx_link_func_module_version_31 31
 
 
 #define ngx_link_func_content_type_plaintext "text/plain"
@@ -68,7 +68,7 @@ extern void ngx_link_func_log_info(ngx_link_func_ctx_t *ctx, const char* msg);
 extern void ngx_link_func_log_warn(ngx_link_func_ctx_t *ctx, const char* msg);
 extern void ngx_link_func_log_err(ngx_link_func_ctx_t *ctx, const char* msg);
 
-extern u_char* ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key);
+extern u_char* ngx_link_func_get_header(ngx_link_func_ctx_t *ctx, const char*key, size_t keylen);
 extern void* ngx_link_func_get_query_param(ngx_link_func_ctx_t *ctx, const char *key);
 extern void* ngx_link_func_palloc(ngx_link_func_ctx_t *ctx, size_t size);
 extern void* ngx_link_func_pcalloc(ngx_link_func_ctx_t *ctx, size_t size);