Chore/fix connecting issue with client (#261)

* chore: fix issue with config

* fix issue with the connection logic

* fix issue with the connection logic

* ci: apply automated fixes

* fix tests

* fix

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: AlemTuzlak

.changeset/full-humans-create.md

@@ -0,0 +1,5 @@
+---
+'@tanstack/devtools-utils': patch
+---
+
+fix issue with client connectivity by not calling the connect method multiple times

packages/event-bus-client/src/plugin.ts

@@ -29,9 +29,12 @@ export class EventClient<
   #connectEveryMs: number
   #retryCount = 0
   #maxRetries = 5
+  #connecting = false
+
   #onConnected = () => {
     this.debugLog('Connected to event bus')
     this.#connected = true
+    this.#connecting = false
     this.debugLog('Emitting queued events', this.#queuedEvents)
     this.#queuedEvents.forEach((event) => this.emitEventToBus(event))
     this.#queuedEvents = []
@@ -41,30 +44,39 @@ export class EventClient<
       this.#onConnected,
     )
   }
-  #connectFunction = () => {
-    this.#eventTarget().addEventListener(
-      'tanstack-connect-success',
-      this.#onConnected,
-    )
+  // fired off right away and then at intervals
+  #retryConnection = () => {
     if (this.#retryCount < this.#maxRetries) {
       this.#retryCount++
       this.dispatchCustomEvent('tanstack-connect', {})
+
       return
     }
-
     this.#eventTarget().removeEventListener(
       'tanstack-connect',
-      this.#connectFunction,
+      this.#retryConnection,
     )
+
     this.debugLog('Max retries reached, giving up on connection')
     this.stopConnectLoop()
   }
 
+  // This is run to register connection handlers on first emit attempt
+  #connectFunction = () => {
+    if (this.#connecting) return
+    this.#connecting = true
+    this.#eventTarget().addEventListener(
+      'tanstack-connect-success',
+      this.#onConnected,
+    )
+    this.#retryConnection()
+  }
+
   constructor({
     pluginId,
     debug = false,
     enabled = true,
-    reconnectEveryMs = 1000,
+    reconnectEveryMs = 300,
   }: {
     pluginId: TPluginId
     debug?: boolean
@@ -83,16 +95,18 @@ export class EventClient<
   }
 
   private startConnectLoop() {
+    // if connected, trying to connect, or the internalId is already set, do nothing
     if (this.#connectIntervalId !== null || this.#connected) return
     this.debugLog(`Starting connect loop (every ${this.#connectEveryMs}ms)`)
 
     this.#connectIntervalId = setInterval(
-      this.#connectFunction,
+      this.#retryConnection,
       this.#connectEveryMs,
     ) as unknown as number
   }
 
   private stopConnectLoop() {
+    this.#connecting = false
     if (this.#connectIntervalId === null) {
       return
     }
@@ -203,7 +217,7 @@ export class EventClient<
         pluginId: this.#pluginId,
       })
       // start connection to event bus
-      if (typeof CustomEvent !== 'undefined') {
+      if (typeof CustomEvent !== 'undefined' && !this.#connecting) {
         this.#connectFunction()
         this.startConnectLoop()
       }