From b5e42fce77d3d064800bba293e8bbe1de2188d3d Mon Sep 17 00:00:00 2001
From: Thiago Carneiro <72167913+thiago-carneiro@users.noreply.github.com>
Date: Sat, 27 Sep 2025 22:04:15 -0300
Subject: [PATCH] Fix: correct sliceInRange stop clamp for non-zero origin
 domains

The previous implementation clamped stop against domain.shape()[i] (size) instead of origin+shape, causing inverted intervals (start > stop) when origins were non-zero. Updated logic now computes the true exclusive upper bound and clamps correctly. Zero-origin behavior unchanged.
---
 mdio/variable.h | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/mdio/variable.h b/mdio/variable.h
index cd1c1c7..eedebdc 100644
--- a/mdio/variable.h
+++ b/mdio/variable.h
@@ -965,13 +965,15 @@ class Variable {
 
     for (size_t idx = 0; idx < labels.size(); ++idx) {
       if (labels[idx] == desc.label) {
-        // Clamp the descriptor to the domain.
-        return {desc.label,  // label
-                desc.start < domain.origin()[idx] ? domain.origin()[idx]
-                                                  : desc.start,  // start
-                desc.stop > domain.shape()[idx] ? domain.shape()[idx]
-                                                : desc.stop,  // stop
-                desc.step};                                   // step
+        // Clamp the descriptor to the domain using absolute coordinates.
+        // NOTE: domain.shape()[idx] is a size, not an absolute upper bound when
+        // the origin is non-zero. The correct exclusive upper bound is
+        // origin + shape.
+        Index dim_origin = domain.origin()[idx];
+        Index dim_upper = dim_origin + domain.shape()[idx];  // exclusive
+        Index clamped_start = desc.start < dim_origin ? dim_origin : desc.start;
+        Index clamped_stop = desc.stop > dim_upper ? dim_upper : desc.stop;
+        return {desc.label, clamped_start, clamped_stop, desc.step};
       }
     }
     // We don't slice along a dimension that doesn't exist, so the descriptor is